Skip to content

25.8.16 Stable: disable write_marks_for_substreams_in_compact_parts by default#1407

Merged
zvonand merged 1 commit intoreleases/25.8.16from
fix/25.8.16/disable-write_marks_for_substreams_in_compact_parts
Feb 17, 2026
Merged

25.8.16 Stable: disable write_marks_for_substreams_in_compact_parts by default#1407
zvonand merged 1 commit intoreleases/25.8.16from
fix/25.8.16/disable-write_marks_for_substreams_in_compact_parts

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Feb 16, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

disable write_marks_for_substreams_in_compact_parts by default

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@zvonand zvonand added 25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable labels Feb 16, 2026
@github-actions
Copy link

Workflow [PR], commit [98b1107]

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@besteffects
Copy link
Member

Verified that this fixed downgrade to 25.3.8.10041.altinitystable

@CarlosFelipeOR
Copy link
Collaborator

CI Failures Analysis

Regression Test - Iceberg Suite

Already fixed in PR #1411. Tests will pass after merge.

Integration tests (RabbitMQ)

Intermittent CI infrastructure issue (unrelated to this PR). Tests passed on rerun.

Stateless tests (amd_debug builds)

Root cause: Changing write_marks_for_substreams_in_compact_parts default to false breaks reading nested JSON arrays from compact MergeTree parts.

Failing tests:

  • 01825_type_json_in_array
  • 01825_type_json_17
  • 03208_array_of_json_read_subcolumns_1

All other stateless failures (Fatal messages, Killed by signal, Exception in test runner, etc.) are cascade failures caused by server crash (SIGABRT) during these JSON tests.

Stateless tests (amd_binary builds)

Pre-existing flaky tests (unrelated to this PR):

  • 02813_starting_in_text_log - flaky since July 2025
  • 03207_json_read_subcolumns_2_wide_merge_tree - flaky since May 2025
  • 03251_insert_sparse_all_formats - flaky since August 2025

Issue created: #1412
Adding verified-with-issue label.

@CarlosFelipeOR CarlosFelipeOR added the verified-with-issue Verified by QA and issue(s) found. label Feb 17, 2026
@zvonand zvonand merged commit f1a5f8e into releases/25.8.16 Feb 17, 2026
1674 of 1730 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable verified-with-issue Verified by QA and issue(s) found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants