Skip to content

[PWGJE] Modification 3-prong to n-prong for b-jet#16044

Open
hanseopark wants to merge 7 commits intoAliceO2Group:masterfrom
hanseopark:HFTagging
Open

[PWGJE] Modification 3-prong to n-prong for b-jet#16044
hanseopark wants to merge 7 commits intoAliceO2Group:masterfrom
hanseopark:HFTagging

Conversation

@hanseopark
Copy link
Copy Markdown
Contributor

DataModel?JetTagging.h

  • To add N-Prong table

TableProducer/secondaryVertexReconstrcution.cxx

  • To add NProng producer

TableProducer/jetTaggerHF.cxx

  • To change 3Prong to N-Prong

Tasks/bjetCentMult.cxx

  • To change 3Prong to N-Prong and modify the histogram name

Tasks/jetTaggerHFQA.cxx

  • To remove the 2-prong task and change 3prong to n-prong

hanseopark added 2 commits May 1, 2026 01:00
Add bjet multiplcity analysis

fix CMakeList

fix to complict rebase

modificaiton validation of flavour and seconday contamition

fix CMakeList
issue of rebase

fix issue of rebase 2

fix issue of rebase 3

to change the name
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 5 disabled

@hanseopark
Copy link
Copy Markdown
Contributor Author

@hahassan7 Hello Hadi,
Please could you check the code?

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 395d2c6 at 2026-04-30 18:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:23: error: 'JetTaggerhfMcdCharged' was not declared in this scope; did you mean 'JetTaggerhfMCDCharged'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:45: error: no matching function for call to 'adaptAnalysisTask<<expression error> >(const o2::framework::ConfigContext&, o2::framework::SetDefaultProcesses)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:45: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:74: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e60498c at 2026-04-30 18:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:23: error: 'JetTaggerhfMcdCharged' was not declared in this scope; did you mean 'JetTaggerhfMCDCharged'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:45: error: no matching function for call to 'adaptAnalysisTask<<expression error> >(const o2::framework::ConfigContext&, o2::framework::SetDefaultProcesses)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:45: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/TableProducer/jetTaggerHF.cxx:743:74: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 1, 2026

Error while checking build/O2Physics/o2 for c35e01a at 2026-05-01 09:43:

## sw/BUILD/O2Physics-latest/log
[ERROR] invalid workflow in /sw/BUILD/30659b87663ff00cdcb05f66886435be67fb1dfc/O2Physics/stage/bin/o2-analysis-je-jet-taggerhf: Cannot use any of ,;:"'$ as DataProcessor name
ninja: build stopped: subcommand failed.

Full log here.

@hahassan7
Copy link
Copy Markdown
Collaborator

Hi @hanseopark ,
Thanks for making these changes, the code looks good to me. Although there are some limitations with your method, it only allows for either 2 or 3 prong SV reconstruction. If you want both, you can't use this method, instead you will have to activate the 2prong and 3prong functions. But for tagging the old limitation is still there, you can only tag either 2 or 3 prong SV you can't use both. But this is not a big problem. I think the code can approved the way it is.

@hanseopark
Copy link
Copy Markdown
Contributor Author

Hi @hanseopark , Thanks for making these changes, the code looks good to me. Although there are some limitations with your method, it only allows for either 2 or 3 prong SV reconstruction. If you want both, you can't use this method, instead you will have to activate the 2prong and 3prong functions. But for tagging the old limitation is still there, you can only tag either 2 or 3 prong SV you can't use both. But this is not a big problem. I think the code can approved the way it is.

This is the issue I was worried about.
In my opinion, performing a side-by-side comparison using tags will ultimately be difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants