[PWGHF] [xic0omegac0] Updated candidate creator & candidate selector by jinhyunni · Pull Request #16042 · AliceO2Group/O2Physics

jinhyunni · 2026-04-30T13:11:41Z

candidateCreatorXic0Omegac0Qa:

Removed unused configurables massOfBach, massOfCharmBaryon
Removed unnecessary configurables for storing pdg Id of final state hadrons in case of anti-Xic0

candidateSelectorToXiPiQa:

Removed continue statement inside candidate loop

github-actions · 2026-04-30T13:12:00Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

vkucera · 2026-04-30T13:15:57Z

  int pdgIdOfV0DauPos, pdgIdOfV0DauNeg, pdgIdOfBach, pdgIdOfCharmBach;
-  int pdgIdOfAntiV0DauPos, pdgIdOfAntiV0DauNeg, pdgIdOfAntiBach, pdgIdOfAntiCharmBach;
  int pdgIdOfV0, pdgIdOfCascade, pdgIdOfCharmBaryon;

  // Track PID - Used in DCAFitter
  int trackPidOfCascade;

  // Mass of daughter tracks & V0s & cascades & charm baryons;
-  float massOfV0DauPos, massOfV0DauNeg, massOfBach, massOfCharmBach;
-  float massOfV0, massOfCascade, massOfCharmBaryon;
+  float massOfV0DauPos, massOfV0DauNeg, massOfCharmBach;
+  float massOfV0, massOfCascade;


Always initialise in declaration.

Hi @vkucera,
They are set to be initialized within init function.
Do they still needed to be initialized at the moment of declaration?

Yes, it can be just with {}, but it should always be there.

I wasn't aware of that issue.
Thanks for letting me know!
I've added commit to incorporate your comment.

Hi @vkucera,
If you have a moment, could you have a look at the updated PR and check if everythis looks good on your side?

I don't know why you linked a formatting PR and why you think it fixed O2 linter warnings.

Because after merging that formatting PR, all the checks were passed.
I double checked by running o2_linter.py locally to see if any warnings or errors occur.

Or am I missing something?

The formatting PR just removed trailing spaces on one line. That cannot change the result of the O2 linter check.
What do you have locally on these lines?

PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:298 PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:445

Sorry, I've missed that part...
I checked and fixed name of the functions located on the lines you've provided.
After making changes, I've checked locally and saw linter passes without any warnings.

I learnd a new thing about formatting PR. Thanks:)

OK, thanks.

zhangbiao-phy · 2026-04-30T13:17:08Z

candidateCreatorXic0Omegac0Qa:

Removed unused configurables massOfBach, massOfCharmBaryon

Removed unnecessary configurables for storing pdg Id of final state hadrons in case of anti-Xic0

candidateSelectorToXiPiQa:

Removed continue statement inside candidate loop

Hi @jinhyunni, why you remove continue? then which means you can't filter the candidates based on BDT preselection, this is really you want to do?

jinhyunni · 2026-04-30T13:26:14Z

candidateCreatorXic0Omegac0Qa:

Removed unused configurables massOfBach, massOfCharmBaryon

Removed unnecessary configurables for storing pdg Id of final state hadrons in case of anti-Xic0

candidateSelectorToXiPiQa:

Removed continue statement inside candidate loop

Hi @jinhyunni, why you remove continue? then which means you can't filter the candidates based on BDT preselection, this is really you want to do?

Hi @zhangbiao-phy.
This action was done to prevent the possible error we've dicussed in the mattermost.
I though if I leave continue statement within in the candidate loop, than the output of candidate selection table might have different rows with candidate table.
That's why I removed them.

zhangbiao-phy · 2026-04-30T14:01:46Z

candidateCreatorXic0Omegac0Qa:

Removed unused configurables massOfBach, massOfCharmBaryon

Removed unnecessary configurables for storing pdg Id of final state hadrons in case of anti-Xic0

candidateSelectorToXiPiQa:

Removed continue statement inside candidate loop

Hi @jinhyunni, why you remove continue? then which means you can't filter the candidates based on BDT preselection, this is really you want to do?

Hi @zhangbiao-phy. This action was done to prevent the possible error we've dicussed in the mattermost. I though if I leave continue statement within in the candidate loop, than the output of candidate selection table might have different rows with candidate table. That's why I removed them.

Hi @jinhyunni, I see your point. maybe we can try to address this at a later stage, when you subscribe to the table. You can refer to the solution used for the 3-prong case here:

O2Physics/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx

Lines 1165 to 1166 in 482efe6

    
           soa::Join<aod::HfCand3ProngWPidPiKaPr, aod::HfSelLc> const& candidates, 
        
           aod::HfMlLcToPKPi const& candidateMlScores,

. If you remove the continue here, the final tree will become very large. This issue will be even more pronounced in Pb–Pb analyses.

jinhyunni · 2026-04-30T14:38:45Z

candidateCreatorXic0Omegac0Qa:

Removed unused configurables massOfBach, massOfCharmBaryon

Removed unnecessary configurables for storing pdg Id of final state hadrons in case of anti-Xic0

candidateSelectorToXiPiQa:

Removed continue statement inside candidate loop

Hi @jinhyunni, why you remove continue? then which means you can't filter the candidates based on BDT preselection, this is really you want to do?

Hi @zhangbiao-phy. This action was done to prevent the possible error we've dicussed in the mattermost. I though if I leave continue statement within in the candidate loop, than the output of candidate selection table might have different rows with candidate table. That's why I removed them.

Hi @jinhyunni, I see your point. maybe we can try to address this at a later stage, when you subscribe to the table. You can refer to the solution used for the 3-prong case here:

O2Physics/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx

Lines 1165 to 1166 in 482efe6

soa::Join<aod::HfCand3ProngWPidPiKaPr, aod::HfSelLc> const& candidates,

aod::HfMlLcToPKPi const& candidateMlScores,

. If you remove the continue here, the final tree will become very large. This issue will be even more pronounced in Pb–Pb analyses.

Thanks for your thoughtful comment on this update.
I'm not sure if it's the best way to mitigate this issue, but for now, I've swaped the order of filling candidate selection table.

Please consider the following formatting changes to AliceO2Group#16042

jinhyunni · 2026-04-30T14:44:10Z

And sorry for accidentaly closing this PR without appropriate consultion.
I wanted to push the comment button, but accidently pushed close this comment button 😅

jinhyunni · 2026-05-01T07:47:41Z

Hi @zhangbiao-phy.
If you have a moment, could you have a look at the updated PR and check if everythis looks good on your side?

zhangbiao-phy · 2026-05-01T11:24:02Z

Hi @zhangbiao-phy. If you have a moment, could you have a look at the updated PR and check if everythis looks good on your side?

Hi @jinhyunni, Thanks! Looks good to me!

jinhyunni · 2026-05-01T11:28:45Z

Hi @zhangbiao-phy. If you have a moment, could you have a look at the updated PR and check if everythis looks good on your side?

Hi @jinhyunni, Thanks! Looks good to me!

Thanks :)

Jinhyun Park added 2 commits April 30, 2026 21:53

[xic0omegac0] Updated candidate creator & candidate selector

1e0b934

[xic0omegac0] Removed unused configurables

f23a53e

jinhyunni requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano, vkucera and zhangbiao-phy as code owners April 30, 2026 13:11

github-actions Bot added the pwghf PWG-HF label Apr 30, 2026

github-actions Bot changed the title ~~[xic0omegac0] Updated candidate creator & candidate selector~~ [PWGHF] [xic0omegac0] Updated candidate creator & candidate selector Apr 30, 2026

vkucera reviewed Apr 30, 2026

View reviewed changes

Jinhyun Park added 2 commits April 30, 2026 23:03

Added initiliazation to variables

b7d4dcd

Re-aranged selection step

15c144c

alibuild mentioned this pull request Apr 30, 2026

Please consider the following formatting changes to #16042 jinhyunni/O2Physics#21

Merged

jinhyunni closed this Apr 30, 2026

jinhyunni reopened this Apr 30, 2026

alibuild and others added 2 commits April 30, 2026 14:39

Please consider the following formatting changes

5d0a4f7

Merge pull request #21 from alibuild/alibot-cleanup-16042

f2aa1fb

Please consider the following formatting changes to AliceO2Group#16042

Fixed linter issues

c16043f

Conversation

jinhyunni commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhangbiao-phy commented Apr 30, 2026

Uh oh!

jinhyunni commented Apr 30, 2026

Uh oh!

zhangbiao-phy commented Apr 30, 2026

Uh oh!

jinhyunni commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinhyunni commented Apr 30, 2026

Uh oh!

jinhyunni commented May 1, 2026

Uh oh!

zhangbiao-phy commented May 1, 2026

Uh oh!

jinhyunni commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

jinhyunni commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

jinhyunni commented Apr 30, 2026 •

edited

Loading