Skip to content

[PWGCF] adding new task for multiparticle cumulants#15997

Merged
abilandz merged 5 commits intoAliceO2Group:masterfrom
pykuan:master
May 1, 2026
Merged

[PWGCF] adding new task for multiparticle cumulants#15997
abilandz merged 5 commits intoAliceO2Group:masterfrom
pykuan:master

Conversation

@pykuan
Copy link
Copy Markdown
Contributor

@pykuan pykuan commented Apr 28, 2026

No description provided.

@github-actions github-actions Bot added the pwgcf label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026 •
edited
Loading

O2 linter results: ❌ 2 errors, ⚠️ 5 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title adding new task for multiparticle cumulants [PWGCF] adding new task for multiparticle cumulants Apr 28, 2026
@alibuild alibuild mentioned this pull request Apr 28, 2026
Closed
vkucera
vkucera reviewed Apr 28, 2026
View reviewed changes
Comment thread PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx Outdated
vkucera
vkucera reviewed Apr 28, 2026
View reviewed changes
Comment thread PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx Outdated
vkucera
vkucera previously requested changes Apr 28, 2026
View reviewed changes
Comment thread PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx Outdated
Comment on lines +21 to +24
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/DataTypes.h"
#include "Framework/runDataProcessing.h"
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a wrong format.

Copy link
Copy Markdown
Contributor Author

@pykuan pykuan Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask what's wrong with the format?

Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need angle brackets for external headers.

Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read this. https://aliceo2group.github.io/analysis-framework/docs/tools/#fixing-include-format

@alibuild alibuild mentioned this pull request Apr 28, 2026
Closed
wenyaCern
wenyaCern previously approved these changes Apr 29, 2026
View reviewed changes
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 29, 2026

Error while checking build/O2Physics/o2 for c1a4fb7 at 2026-04-29 08:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:647:10: error: 'THIF' was not declared in this scope; did you mean 'THnF'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:647:16: error: expected primary-expression before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:651:3: error: expected primary-expression before '}' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:651:3: error: expected ';' before '}' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:651:3: error: expected primary-expression before '}' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:651:3: error: expected ')' before '}' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:651:3: error: expected primary-expression before '}' token
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx Outdated
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx Outdated
qa.fQAHistogramsList->Add(qa.fQAHistograms[eQACent][0]);

wt.fWeightHistograms = getHistogramsWithWeights(tc.fFileWithWeights.c_str(), tc.fRunNumber.c_str());
for (THIF* const& hist : wt.fWeightHistograms) {
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Here const& doesn't make sense because you have pointers. Silence the O2 linter error.
  • You should not use explicit casting here. Either it is redundant or it is wrong.

@vkucera vkucera marked this pull request as draft April 29, 2026 07:34
@pykuan pykuan marked this pull request as ready for review May 1, 2026 14:42
@pykuan pykuan requested a review from abilandz as a code owner May 1, 2026 14:42
@pykuan
Copy link
Copy Markdown
Contributor Author

pykuan commented May 1, 2026

Dear @vkucera,

The remaining automated compilation checks seem to be stuck with the message “Security: approval needed, not starting”. My supervisor mentioned that this is not related to the code itself.

Could you please let me know whom I should contact to approve or restart these checks?

@vkucera vkucera marked this pull request as draft May 1, 2026 15:15
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 1, 2026

Dear @vkucera,

The remaining automated compilation checks seem to be stuck with the message “Security: approval needed, not starting”. My supervisor mentioned that this is not related to the code itself.

Could you please let me know whom I should contact to approve or restart these checks?

You still have not fixed the includes.
The build checks will run when your PR gets approved.
To get your PR merged, you need an approval from the code owners, listed here.
Please read the contribution guidelines. It is explained there.

@abilandz abilandz marked this pull request as ready for review May 1, 2026 15:52
@abilandz abilandz enabled auto-merge (squash) May 1, 2026 16:16
@abilandz abilandz dismissed vkucera’s stale review May 1, 2026 16:24

Dear vkucera, Thanks a lot for your expert review, fully appreciated from our side! We will fix the headers, as you requested, in the next PR, so that we can close the current one, and proceed with other important checks!

@abilandz abilandz merged commit 9930e12 into AliceO2Group:master May 1, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@abilandz abilandz abilandz approved these changes

@victor-gonzalez victor-gonzalez victor-gonzalez left review comments

@wenyaCern wenyaCern wenyaCern left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pykuan @alibuild @vkucera @victor-gonzalez @abilandz @wenyaCern