[PWGLF] Fix includes by vkucera · Pull Request #15874 · AliceO2Group/O2Physics

vkucera · 2026-04-20T11:09:30Z

Requires #15872

github-actions · 2026-04-20T11:09:45Z

O2 linter results: ❌ 217 errors, ⚠️ 60 warnings, 🔕 0 disabled

alibuild · 2026-04-20T13:42:36Z

Error while checking build/O2Physics/o2 for 765af83 at 2026-04-20 21:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:539:79: error: 'McCollsExtra' is not a member of 'o2::aod'; did you mean 'MultsExtra'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:539:91: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:539:31: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:547:21: error: 'ColMCTrueTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:547:46: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:659:21: error: 'ColMCTrueTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:659:46: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:687:27: error: 'ColMCTrueTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:687:52: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:750:27: error: 'ColMCTrueTable' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:750:52: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:552:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:557:19: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:559:31: error: 'RecCols' was not declared in this scope; did you mean 'RecCol'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:566:28: error: 'RecTracks' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:569:52: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:569:54: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:611:31: error: 'mfttracks' was not declared in this scope; did you mean 'lrmfttracks'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:625:35: error: 'besttracks' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:630:62: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:630:64: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:640:35: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:547:37: error: unused parameter 'iterator' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:662:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:667:19: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:669:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:659:37: error: unused parameter 'iterator' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:690:18: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:694:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:700:33: error: 'RecCols' was not declared in this scope; did you mean 'RecCol'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:707:71: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:714:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:718:40: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:721:31: error: 'RecCols' was not declared in this scope; did you mean 'RecCol'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:728:69: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:731:28: error: 'RecTracks' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:744:44: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:687:43: error: unused parameter 'iterator' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:753:18: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:757:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:763:33: error: 'RecCols' was not declared in this scope; did you mean 'RecCol'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:770:71: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:777:33: error: 'mcparticles' was not declared in this scope; did you mean 'particle'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:780:40: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:783:31: error: 'RecCols' was not declared in this scope; did you mean 'RecCol'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:790:69: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:793:28: error: 'mfttracks' was not declared in this scope; did you mean 'lrmfttracks'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/TableProducer/longrangeMaker.cxx:803:44: error: 'mcCollision' was not declared in this scope; did you mean 'lrmccollision'?
[0 more errors; see full log]

Full log here.

alibuild · 2026-04-24T11:38:50Z

Error while checking build/O2Physics/o2 for 3652c94 at 2026-04-24 13:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:466:99: error: 'McCollsExtra' is not a member of 'o2::aod'; did you mean 'MultsExtra'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:466:111: error: template argument 4 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:466:33: error: '<expression error>' in namespace 'o2::soa' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1938:19: error: 'CollsMCExtraMult' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1938:46: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2350:18: error: 'CollsMCExtraMult' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2350:45: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1940:20: error: 'CollsMCExtraMult' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1940:12: error: parse error in template argument list
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1940:54: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:1938:37: error: unused parameter 'iterator' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2357:47: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2357:74: error: 'collisions' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2360:26: error: 'particles' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2362:26: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2364:43: error: 'particles' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2373:34: error: 'collisions' was not declared in this scope; did you mean 'collision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2378:72: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2430:34: error: 'collisions' was not declared in this scope; did you mean 'collision'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2432:57: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2432:59: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2443:72: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2448:33: error: 'tracks' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2478:61: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2478:63: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2558:44: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2561:46: error: 'mcCollision' was not declared in this scope; did you mean 'MyCollisions'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/flattenictyPikp.cxx:2350:36: error: unused parameter 'iterator' [-Werror=unused-parameter]
/sw/slc9_x86-64/O2/daily-20260424-0000-local1/include/Framework/AnalysisTask.h:646:58: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::invokeProcess(std::__shared_ptr<FlattenictyPikp, __gnu_cxx::_S_atomic>::element_type&, o2::framework::InputRecord&, void (FlattenictyPikp::*&)(int), std::vector<ExpressionInfo>&, o2::framework::ArrowTableSlicingCache&)'
/sw/slc9_x86-64/O2/daily-20260424-0000-local1/include/Framework/AnalysisTask.h:161:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (FlattenictyPikp::*&)(int), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&)'
/sw/slc9_x86-64/O2/daily-20260424-0000-local1/include/Framework/AnalysisTask.h:172:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (FlattenictyPikp::*&)(int), bool&, o2::framework::Cache&, o2::framework::Cache&)'
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-04-24T13:10:44Z

Ready for merging

Fix includes

765af83

vkucera requested review from HorstMa, abmodak, alibuild, dmallick2, ercolessi, fmazzasc, gbencedi, lhusova, maciacco, mpuccio, omvazque, prottayCMT, romainschotter, skundu692 and smaff92 as code owners April 20, 2026 11:09

github-actions Bot added pwglf datamodel labels Apr 20, 2026

github-actions Bot changed the title ~~Fix includes~~ [PWGLF] Fix includes Apr 20, 2026

romainschotter previously approved these changes Apr 20, 2026

View reviewed changes

romainschotter enabled auto-merge (squash) April 20, 2026 11:16

vkucera mentioned this pull request Apr 20, 2026

Include What You Use #8357

Open

Merge branch 'master' into fixes-PWGLF

3652c94

vkucera marked this pull request as draft April 24, 2026 10:57

auto-merge was automatically disabled April 24, 2026 10:57
Pull request was converted to draft

More fixes

9633eb9

vkucera dismissed romainschotter’s stale review via 9633eb9 April 24, 2026 11:25

vkucera marked this pull request as ready for review April 24, 2026 11:26

vkucera requested a review from romainschotter April 24, 2026 12:14

abmodak approved these changes Apr 24, 2026

View reviewed changes

abmodak enabled auto-merge (squash) April 24, 2026 13:14

skundu692 approved these changes Apr 24, 2026

View reviewed changes

abmodak merged commit 68b8686 into AliceO2Group:master Apr 24, 2026
12 of 14 checks passed

vkucera deleted the fixes-PWGLF branch April 24, 2026 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGLF] Fix includes#15874

[PWGLF] Fix includes#15874
abmodak merged 3 commits intoAliceO2Group:masterfrom
vkucera:fixes-PWGLF

vkucera commented Apr 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

alibuild commented Apr 20, 2026 •

edited

Loading

Uh oh!

alibuild commented Apr 24, 2026

Uh oh!

vkucera commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Conversation

vkucera commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Apr 24, 2026

Uh oh!

vkucera commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

vkucera commented Apr 20, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading

alibuild commented Apr 20, 2026 •

edited

Loading