[PWGJE] Add new D0 substructure task#15311
Draft
pdhankhe wants to merge 3 commits intoAliceO2Group:masterfrom
Draft
[PWGJE] Add new D0 substructure task#15311pdhankhe wants to merge 3 commits intoAliceO2Group:masterfrom
pdhankhe wants to merge 3 commits intoAliceO2Group:masterfrom
Conversation
pdhankhe
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#15311
nzardosh
reviewed
Mar 10, 2026
| angularity /= (jet.pt() * (jet.r() / 100.f)); | ||
| } | ||
| // Collision-level and for Tracks QA | ||
| void processCollisions(aod::JetCollision const& collision, aod::JetTracks const& tracks) |
Collaborator
There was a problem hiding this comment.
why do you do these in a seperate process function?
| SOURCES jetDsSpectrumAndSubstructure.cxx | ||
| PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::PWGJECore O2Physics::AnalysisCore | ||
| COMPONENT_NAME Analysis) | ||
| o2physics_add_dpl_workflow(jet-d0-substructure |
Collaborator
There was a problem hiding this comment.
the name is quite similair to the other D0 substructure task so please consider something different
| } | ||
| angularity += std::pow(constituent.pt(), kappa) * std::pow(jetutilities::deltaR(jet, constituent), alpha); | ||
| } | ||
| angularity /= (jet.pt() * (jet.r() / 100.f)); |
Collaborator
There was a problem hiding this comment.
you havent included kappa and alpha in the denominator
fjonasALICE
reviewed
Mar 10, 2026
| } | ||
| PROCESS_SWITCH(JetD0Substructure, processDataCharged, "charged jets in data", false); | ||
|
|
||
| void processDataChargedSubstructure(aod::JetCollision const& collision, |
Collaborator
There was a problem hiding this comment.
Do you not here also want to apply the JetFilter and EventFilter like you do for processDataCharged with soa::Filtered?
fjonasALICE
reviewed
Mar 10, 2026
| jet.pt(), jet.eta(), jet.phi(), jet.tracks_as<aod::JetTracks>().size(), angularity, | ||
| d0Candidate.pt(), d0Candidate.eta(), d0Candidate.phi(), d0Candidate.m(), d0Candidate.y(), d0Candidate.mlScores()[0], d0Candidate.mlScores()[1], d0Candidate.mlScores()[2]); | ||
|
|
||
| break; // get out of candidates' loop after first HF particle is found in jet |
Collaborator
There was a problem hiding this comment.
I am not an HF-jet expert, but is it desired that one breaks after the first candidate that one finds as part of the jet? Are the d0Candidates somehow or is the order random?
Collaborator
There was a problem hiding this comment.
there should ever only be one in the current code anyways
fjonasALICE
reviewed
Mar 10, 2026
| {"h_d0_jet_eta", ";#eta_{T,D^{0} jet};dN/d#eta_{D^{0} jet}", {HistType::kTH1F, {{250, -5., 5.}}}}, | ||
| {"h_d0_jet_phi", ";#phi_{T,D^{0} jet};dN/d#phi_{D^{0} jet}", {HistType::kTH1F, {{250, -10., 10.}}}}, | ||
| {"h_d0_mass", ";m_{D^{0}} (GeV/c^{2});dN/dm_{D^{0}}", {HistType::kTH1F, {{1000, 0., 10.}}}}, | ||
| {"h_d0_eta", ";#eta_{D^{0}} (GeV/c^{2});dN/d#eta_{D_{}}", {HistType::kTH1F, {{250, -5., 5.}}}}, |
Collaborator
There was a problem hiding this comment.
eta is not unit GeV/c^2
fjonasALICE
reviewed
Mar 10, 2026
| {"h_d0_jet_phi", ";#phi_{T,D^{0} jet};dN/d#phi_{D^{0} jet}", {HistType::kTH1F, {{250, -10., 10.}}}}, | ||
| {"h_d0_mass", ";m_{D^{0}} (GeV/c^{2});dN/dm_{D^{0}}", {HistType::kTH1F, {{1000, 0., 10.}}}}, | ||
| {"h_d0_eta", ";#eta_{D^{0}} (GeV/c^{2});dN/d#eta_{D_{}}", {HistType::kTH1F, {{250, -5., 5.}}}}, | ||
| {"h_d0_phi", ";#phi_{D^{0}} (GeV/c^{2});dN/d#phi_{D^{0}}", {HistType::kTH1F, {{250, -10., 10.}}}}, |
Collaborator
There was a problem hiding this comment.
same comment as above
fjonasALICE
reviewed
Mar 10, 2026
| Produces<aod::JetObjTable> ObjJetTable; | ||
|
|
||
| float angularity; | ||
| float leadingConstituentPt; |
Collaborator
There was a problem hiding this comment.
unused variable (calculated but never used)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new D0 substructure task.