Skip to content

[Common] TPC PID: Cleanup of CCDB accessors#13265

Merged
dsekihat merged 1 commit intoAliceO2Group:masterfrom
jezwilkinson:tpccdbfix
Mar 2, 2026
Merged

[Common] TPC PID: Cleanup of CCDB accessors#13265
dsekihat merged 1 commit intoAliceO2Group:masterfrom
jezwilkinson:tpccdbfix

Conversation

@jezwilkinson
Copy link
Contributor

Updating TPC PID tasks to optimise CCDB access methods:

  • Remove separate calls to "CcdbApi::retrieveHeaders()", use new merged calls to retrieveBlob, getSpecific, getForTimeStamp (avoids pinging CCDB multiple times when accessing info from metadata from retrieved objects)
  • Use BasicCCDBManager::getCCDBAccessor() instead of separate ccdbApi object for retrieveBlob (avoids initialising a second UserAgent for each process)
  • remove unneeded "nullmetadata" object; minor fix to logic for loading information from headers

Depends on AliceO2Group/AliceO2#14709 for updates to CCDB API.

@github-actions github-actions bot added the common label Oct 7, 2025
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

O2 linter results: ❌ 49 errors, ⚠️ 68 warnings, 🔕 0 disabled

@jezwilkinson jezwilkinson marked this pull request as ready for review November 26, 2025 16:23
@amaringarcia
Copy link
Contributor

@ddobrigk would it be possible to have a look at/approve this pull request?
Thanks in advance

@github-actions
Copy link

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 10, 2026
@jezwilkinson
Copy link
Contributor Author

@ktf @jgrosseo @ddobrigk Could someone please take a look at this? The fix was requested by Costin some time ago, it would be good if we can get it merged.

@github-actions github-actions bot removed the stale label Jan 15, 2026
@alibuild
Copy link
Collaborator

alibuild commented Jan 27, 2026

Error while checking build/O2Physics/o2 for 6233bf5 at 2026-02-09 18:15:

No log files found

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Feb 24, 2026

@ddobrigk @iarsene @dsekihat This PR has been opened for review for 3 months without a review.

@dsekihat dsekihat merged commit ac253eb into AliceO2Group:master Mar 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants