Skip to content

[O2B-1558] Set filters from url upon page reload #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 8 commits into
base: impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
Choose a base branch
from

fix for runtype test

e157e08
Select commit
Loading
Failed to load commit list.
Open

[O2B-1558] Set filters from url upon page reload #2144

fix for runtype test
e157e08
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 29, 2026 in 1s

45.80% (-0.09%) compared to 49ed030

View this Pull Request on Codecov

45.80% (-0.09%) compared to 49ed030

Details

Codecov Report

❌ Patch coverage is 18.91892% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.80%. Comparing base (49ed030) to head (e157e08).

Files with missing lines Patch % Lines
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 15 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 10 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 9 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 5 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
...mulationPass/RunsPerSimulationPassOverviewModel.js 0.00% 4 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 2 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 2 Missing ⚠️
.../components/runEorReasons/runEorReasonSelection.js 0.00% 1 Missing ⚠️
...public/views/DataPasses/DataPassesOverviewModel.js 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@                                                             Coverage Diff                                                             @@
##           impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel    #2144      +/-   ##
===========================================================================================================================================
- Coverage                                                                                                    45.89%   45.80%   -0.09%     
===========================================================================================================================================
  Files                                                                                                         1036     1036              
  Lines                                                                                                        17167    17194      +27     
  Branches                                                                                                      3122     3128       +6     
===========================================================================================================================================
- Hits                                                                                                          7878     7876       -2     
- Misses                                                                                                        9289     9318      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov