Skip to content

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 2 commits into
base: improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel
Choose a base branch
from
+9 −6
Open

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel #2141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee70acf
chore: force all filters managed by FilteringModel to extend FilterMo…
Apr 21, 2026
1f9af44
feat: make filteringmodel constructor more efficient
Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/public/components/Filters/common/FilteringModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
*/

import { expandQueryLikeNestedKey } from '../../../utilities/expandNestedKey.js';
import { SelectionModel } from '../../common/selection/SelectionModel.js';
import { FilterModel } from './FilterModel.js';
import { Observable } from '/js/src/index.js';

/**
Expand All @@ -28,12 +30,9 @@ export class FilteringModel extends Observable {

this._visualChange$ = new Observable();

this._filters = filters;
this._filterModels = Object.values(filters);
for (const model of this._filterModels) {
model.bubbleTo(this);
model.visualChange$?.bubbleTo(this._visualChange$);
}
this._filters = {};
this._filterModels = [];
Object.entries(filters).forEach(([key, model]) => this.put(key, model));
}

/**
Expand Down Expand Up @@ -118,6 +117,10 @@ export class FilteringModel extends Observable {
return;
}

if (!(filter instanceof FilterModel || filter instanceof SelectionModel)) {
throw new Error('Filter must extend FilterModel or SelectionModel');
}

this._filters[key] = filter;
this._filterModels.push(filter);
filter.bubbleTo(this);
Expand Down
Loading