Skip to content

[O2B-1552] Move ad hoc filters inside runs overview model to filtering model#2106

Open
NarrowsProjects wants to merge 6 commits intoimprov/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel
Open

[O2B-1552] Move ad hoc filters inside runs overview model to filtering model#2106
NarrowsProjects wants to merge 6 commits intoimprov/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 10, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • ddflpFilter, dcsFilter and epnFilter have been moved to the filteringModel
  • A new component called RadioButtonFilter has ben added and has replaced the filters that corresponded with the previous ly mentioned filters

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Mar 10, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.98%. Comparing base (e2ab763) to head (1cd5603).

Files with missing lines Patch % Lines
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 4 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 3 Missing ⚠️
...omponents/Filters/common/RadioButtonFilterModel.js 0.00% 2 Missing ⚠️
...onents/Filters/common/filters/radioButtonFilter.js 0.00% 2 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 1 Missing ⚠️
...lagTypes/ActiveColumns/qcFlagTypesActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                               Coverage Diff                                                @@
##           improv/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-pattern    #2106      +/-   ##
================================================================================================================
+ Coverage                                                                         45.87%   45.98%   +0.10%     
================================================================================================================
  Files                                                                              1042     1043       +1     
  Lines                                                                             17158    17120      -38     
  Branches                                                                           3104     3094      -10     
================================================================================================================
  Hits                                                                               7872     7872              
+ Misses                                                                             9286     9248      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel branch from a640a39 to 639180b Compare March 10, 2026 16:31
@NarrowsProjects NarrowsProjects changed the title Improv/o2 b 1552/move ad hoc filters inside runs overview model to filtering model [O2B-1552] Move ad hoc filters inside runs overview model to filtering model Mar 10, 2026
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel branch from 639180b to abad042 Compare March 10, 2026 16:46
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel branch from abad042 to 1cd5603 Compare March 10, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant