Skip to content

[O2B-1547] Migrate lhc period overview model to use filtering model pattern#2105

Open
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-pattern
Open

[O2B-1547] Migrate lhc period overview model to use filtering model pattern#2105
NarrowsProjects wants to merge 4 commits intoimprov/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-patternfrom
improv/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 10, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • pdpBeamTypesFilterModel, namesFilterModel and yearsFilterModel are now stored in a FilteringModel instance
  • pdpBeamTypesFilterModel, namesFilterModel and yearsFilterModel must now be accessed using the FilteringModel.get() funtion

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Mar 10, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.87%. Comparing base (6fe055b) to head (e2ab763).

Files with missing lines Patch % Lines
...ews/lhcPeriods/Overview/LhcPeriodsOverviewModel.js 0.00% 10 Missing ⚠️
...hcPeriods/ActiveColumns/lhcPeriodsActiveColumns.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                                                                              Coverage Diff                                                                              @@
##           improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern    #2105      +/-   ##
=============================================================================================================================================================================
+ Coverage                                                                                                                                      45.84%   45.87%   +0.03%     
=============================================================================================================================================================================
  Files                                                                                                                                           1042     1042              
  Lines                                                                                                                                          17171    17158      -13     
  Branches                                                                                                                                        3105     3104       -1     
=============================================================================================================================================================================
  Hits                                                                                                                                            7872     7872              
+ Misses                                                                                                                                          9299     9286      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant