Skip to content

[O2B-1549] Migrate anchored simulation passes overview model and simulation passes per lhc period overview model to use filtering model pattern#2103

Closed
NarrowsProjects wants to merge 43 commits intomainfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern
Closed

[O2B-1549] Migrate anchored simulation passes overview model and simulation passes per lhc period overview model to use filtering model pattern#2103
NarrowsProjects wants to merge 43 commits intomainfrom
improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 10, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • The AnchoredSimulationPassOverviewModel file now stores its filter in a FilteringModel instance.
  • The names filter must now be accessed through the FilteringModel.get function

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
chore: remove redundant model assignment.
722caf7
chore: move all filters denoted as so to a filteringModel
f161cae
Make filterInputModel extend filterModel
9faffaf
rename inputfilter to ParsedInputFilter
247943b
implement authorfilter with ParsedInputFilterModel changes
114285d
re-implement filter
f39f7ae
add tag-filters to the filtering object
df1fea3
replace titleFilter and contentFilter with RawTextFilterModels
96ca85f
make Authorfilter an implementation of RawTextFilterModel
93b3291
add runs filter to the filteringmodel
5a5e830
add environments filter to the filteringmodel
b5e7148
add lhcFills filter to the filteringmodel
3507ba0
add created filter to the filteringmodel
9c63409
move the sort 'filter' to fetchlogs, since it doesn't actually filter…
5500b3e 
… anything
change filter to rawTextFilter for title
a09ae8b
fix test by changing event type to 'change'
512999b
fix content and author tests
0f15812
import openFilteringPanel and resetFilters
7b641ca
fix createdAt filter test
5ab8218
change event types to change
4c96d73
fix isAnyFilterActive
18ce4dc
remove _raw as from authorfilterModel, as it serves no purpose
685dd38
chore: removed ParsedInputFilterModel
4e132fd
chore: add toLowerCase to filterQueryParam computation
caf9812
@NarrowsProjects
[O2B-1530] Lhc fills add sb duration filter (#2080)
41c5a72 
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
@isaachilly
[O2B-1544] Fix pagination for filtered envs and add a test (#2096)
f38f597 
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
remove the combination operator from runs
3efdf1d
remove the combination operator from envirionments
fc61bea
remove the combination operator from lhcFills
9c4df68
make filter computation much more compact using filteringmodel.normalize
b860320
Guust and others added 13 commits March 5, 2026 15:34
add happy-flow tests for logs api
7a00043
fix usecase unit tests
ada3eb3
@NarrowsProjects
Merge branch 'main' into improv/O2B-1534/Migrate-Log-Overview-to-use-…
d290be7 
…FilteringModel-pattern
@NarrowsProjects
Merge branch 'main' into improv/O2B-1534/Migrate-Log-Overview-to-use-…
0d8d3d4 
…FilteringModel-pattern
@NarrowsProjects
Merge branch 'main' into improv/O2B-1534/Migrate-Log-Overview-to-use-…
237683a 
…FilteringModel-pattern
chore: add filteringmodel to QcFlagTypesOverviewModel
25244f4
feat: move namesFilterModelFilter to fileringmodel
6970a74
feat: move methodsFilterModelFilter to filteringModel
cdaaf0e
feat: move methodsFilterModelFilter to filteringModel
27a8bbc
chore: add filteringModel to AnchoredSimulationPassesOverviewModel
c24d302
chore: add namesFilterModel to the filteringModel instance
2f6fcf1
chore: add filteringModel to SimulationPassesPerLhcPeriodOverviewModel
790d76b
chore: add namesFilterModel to the filteringModel instance of Simulat…
6fe055b 
…ionPassesPerLhcPeriodOverviewModel
@NarrowsProjects NarrowsProjects self-assigned this Mar 10, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaachilly isaachilly Awaiting requested review from isaachilly

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NarrowsProjects @isaachilly