[O2B-1546] Improvements on SYNC QC flags per Detector#2101
Merged
isaachilly merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
Introduce a dedicated synchronousQcFlagsActiveColumns config. Make formatQcFlagStart/End accept an inline flag and pass it through to formatTimestamp so From/To and Created views can render date/time on one line. Adjust a seeder row to mark a QC flag as deleted so it's text colour can be tested. Update synchronous overview tests to validate combined From/To and CreatedBy cell contents, check comment/createdBy popovers, and assert Deleted cell text and styling.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 45.56% 45.55% -0.01%
==========================================
Files 1043 1044 +1
Lines 17325 17327 +2
Branches 3137 3140 +3
==========================================
Hits 7894 7894
- Misses 9431 9433 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added a new deleted QC flag (id 103). Update API, service and public tests to account for the additional flag and adjust selectors and counters in the UI test. Also fix several test title typos.
graduta
approved these changes
Mar 10, 2026
isaachilly
deleted the
improv/O2B-1546/improvements-to-SYNC-QC-flag-tables
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a dedicated synchronousQcFlagsActiveColumns config.
Make formatQcFlagStart/End accept an inline flag and pass it through to formatTimestamp so From/To and Created views can render date/time on one line.
Adjust seeder file to mark a QC flag as deleted so its text colour can be tested.
Update synchronous overview tests to validate combined From/To and CreatedBy cell contents, check comment/createdBy popovers, and assert Deleted cell text and styling.
Update any tests affected by addition of deleted QC flag.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: