Skip to content

Better coverage#755

Draft
AlexInLog wants to merge 1 commit into
v2from
AlexInLog-patch-1
Draft

Better coverage#755
AlexInLog wants to merge 1 commit into
v2from
AlexInLog-patch-1

Conversation

@AlexInLog

@AlexInLog AlexInLog commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Coverage-enabled test runs now write separate profiler data files per process, helping avoid filename collisions and improving reliability of coverage collection.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a310af15-9819-42ae-9ef4-04c79e1f7c33

📥 Commits

Reviewing files that changed from the base of the PR and between d54535d and 6502a87.

📒 Files selected for processing (1)
  • CMakeLists.txt

📝 Walkthrough

Walkthrough

The add_test_with_coverage macro in CMakeLists.txt is updated so the LLVM coverage profiler writes output using a per-process filename pattern (${TARGET}-%p.profraw) instead of a single fixed filename (${TARGET}.profraw).

Changes

Coverage Output Naming

Layer / File(s) Summary
Per-process profraw filename
CMakeLists.txt
LLVM_PROFILE_FILE now includes the %p process ID placeholder in the profraw filename pattern instead of a single fixed name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

One line hopped, a tweak so small,
%p joins in, avoiding a brawl,
No more clashes when tests run wide,
Each process now writes with pride. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and doesn’t describe the specific coverage instrumentation change in CMakeLists.txt. Rename it to reflect the actual change, e.g. per-process LLVM profiler output filenames for coverage tests.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch AlexInLog-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant