Add \Device\KsecDD emulation and mask 32-bit syscall arguments#1
Closed
ELJoOker2004 wants to merge 6 commits into
Closed
Add \Device\KsecDD emulation and mask 32-bit syscall arguments#1ELJoOker2004 wants to merge 6 commits into
ELJoOker2004 wants to merge 6 commits into
Conversation
- Emulate \Device\KsecDD (RNG + memory encrypt/decrypt) so the bcrypt/CNG DllMain succeeds during Windows PE process initialization. - Mask ULONG syscall arguments that were read as 64-bit; some ntdll builds leave garbage in the upper 32 bits, which broke handler argument checks.
Owner
|
Looks good to go. can you just remove the unnecessary comments in the code? |
Owner
|
Looks like the commit doesn't align with the latest changes in the repo, can you also fix that? |
Owner
|
Sorry but this breaks the build, can you re-fork it and add your changes again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue I faced when testing where my ntdll version was newer, I think, so the process aborted during initialization and never reached main. Two root causes:
Can you please verify before merge?