testing: Check in ref images for Mac ARM debug case#2083
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
testing: Check in ref images for Mac ARM debug case#2083lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
lgritz
force-pushed
the
lg-macosdebugref
branch
from
8332717 to
d3f90f8
Compare
We don't test this in CI so it's probably gone undetected for a while, but there are a few tests that differ slightly for the combination of ARM-based Mac for debug builds. So check in a few more ref images so that devs using that platform don't get spurious testsuite failures for debug builds. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
force-pushed
the
lg-macosdebugref
branch
from
d3f90f8 to
c0cf5fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't test this in CI so it's probably gone undetected for a while, but there are a few tests that differ slightly for the combination of ARM-based Mac for debug builds, as I discovered at home after recently switching from an Intel to an ARM based laptop. So check in a few more ref images so that devs using that platform don't get spurious testsuite failures for debug builds.