testshade: use renderer's error handler, convert raw pointers to unique_ptr#2082
Open
lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
testshade: use renderer's error handler, convert raw pointers to unique_ptr#2082lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
…ue_ptr Replace the standalone global ErrorHandler with the renderer's own errhandler() so that error output is properly routed through the renderer rather than a disconnected handler. This ensures errors during shading are visible in the same context as the renderer that owns the ShadingSystem. Also replace some raw pointers with `new`/`delete` with std::unique_ptr. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
force-pushed
the
lg-testshade-errhandler
branch
from
6360777 to
2983e48
Compare
Collaborator
Author
|
After Chris's review, I did notice a test failure -- some things were printed in Debug builds but that the split ErrorHandler situation was causing not to show up in the output. After this patch fixed that situation, those extra messages appeared! So I pushed a very minor update to address this and match the old test output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace testshade's standalone global ErrorHandler with the renderer's own errhandler() so that error output is properly routed through the renderer rather than a disconnected handler. This ensures errors during shading are visible in the same context as the renderer that owns the ShadingSystem.
Also replace some raw pointers with
new/deletewith std::unique_ptr.