Add unit tests for Gemma 4 LoRA targeting and NNX caching#4265
Open
RexBearIU wants to merge 2 commits into
Open
Add unit tests for Gemma 4 LoRA targeting and NNX caching#4265RexBearIU wants to merge 2 commits into
RexBearIU wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follow-up PR adds robust, CPU-friendly unit tests for the Gemma 4 LoRA support introduced in #3969.
It implements the precise test coverage requested by reviewers to ensure:
lora_module_path.ymlforgemma4correctly resolves and matches the expected module paths (including MoE paths).Why this is a good solution:
These lightweight unit tests execute in milliseconds on standard CPUs, fully guarding these critical codepaths against future regressions without adding TPU dependency or CI execution overhead.
Related PR: #3969
Tests
To verify these changes, run the following pytest commands:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.