Add YaRN RoPE configuration support and enhance evaluation parameters#4238
Open
JamesDeng42 wants to merge 2 commits into
Open
Add YaRN RoPE configuration support and enhance evaluation parameters#4238JamesDeng42 wants to merge 2 commits into
JamesDeng42 wants to merge 2 commits into
Conversation
- Implemented _apply_yarn_rope_config to preserve HF model-specific fields. - Updated harness_runner to include new flags: apply_chat_template, fewshot_as_multiturn, and gen_kwargs. - Enhanced server_manager to handle token-ID prompts and logprobs. - Added unit tests for new features and configurations.
|
🤖 Hi @JamesDeng42, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
🤖 I'm sorry @JamesDeng42, but I was unable to process your request. Please see the logs for more details. |
entrpn
approved these changes
Jun 23, 2026
ajkv-google
approved these changes
Jun 24, 2026
vlad-karp
approved these changes
Jun 24, 2026
05df1f4 to
f2fba92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests
Added corresponding unit test.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.