feat: Add Gemma3 LoRA SFT integration and programmatic weight mapping…#4004
Draft
RexBearIU wants to merge 1 commit into
Draft
feat: Add Gemma3 LoRA SFT integration and programmatic weight mapping…#4004RexBearIU wants to merge 1 commit into
RexBearIU wants to merge 1 commit into
Conversation
… end-to-end support
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… end-to-end support
Description
This PR adds end-to-end integration and weight-mapping support for Gemma3 LoRA SFT and vLLM decoding. Previously, standalone offline decoding ( vllm_decode.py ) and the online Tunix server ( adapter.py ) lacked the capability
to
map and load LoRA-adapted weights specifically for Gemma3, causing failures during parameter restoration and serving.
Key Changes:
• Gemma3 Weight Mapping: Added gemma3.py mapping to translate Gemma3 layers programmatically between MaxText and HuggingFace/vLLM structures.
• Generalized Restore API: Updated restore_lora_from_path to handle raw nnx.Module models (used in vLLM adapters) in addition to trainer states.
• vLLM Integration: Hooked both online and offline vLLM decode paths to restore LoRA parameters when lora.enable_lora=True .
Tests
1. Unit Tests
• Result: 10 passed
2. End-to-End Tests
Tested the end-to-end flow using the newly converted checkpoint:
Convert Checkpoint:
export HF_TOKEN=
export RUN_ID=$(date +%Y-%m-%d-%H-%M)
bash tests/end_to_end/tpu/gemma3/4b/test_gemma3_to_mt.sh $RUN_ID
Run LoRA & Decode (starts from the newly converted checkpoint above):
bash tests/end_to_end/tpu/gemma3/4b/test_gemma3_lora.sh $RUN_ID
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.