Transition MaxText docker image build workflow to package-based installation#3788
Open
SurbhiJainUSC wants to merge 1 commit intomainfrom
Open
Transition MaxText docker image build workflow to package-based installation#3788SurbhiJainUSC wants to merge 1 commit intomainfrom
SurbhiJainUSC wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
57e66e4 to
8b9df5e
Compare
8b9df5e to
bd2fb51
Compare
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully transitions the MaxText Docker image build process to a package-based installation, which improves consistency and maintainability. It also introduces a valuable automated failure notification system for nightly builds.
🔍 General Feedback
- Redundancy: The
Copy tests assets to package directorystep in the workflow is redundant because the Dockerfile already handles copying tests from the root context. - Brittleness: Hardcoded Python version paths (
python3.12) should be replaced with more dynamic alternatives to future-proof the workflows. - Conventions: The change to image naming (adding an underscore before the suffix) and the use of short SHAs for tagging are positive improvements but should be noted as changes to existing conventions.
- Variables: Ensure
vars.PROJECT_NAMEis defined in the repository settings to prevent build failures.
bd2fb51 to
704fba0
Compare
704fba0 to
52d8035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR transitions the nightly Docker image build workflow from a source-based installation to a package-based installation. This change is to standardize environment setups across all workflows by leveraging the MaxText Python package. Additionally, it introduces an automated notification system to track nightly build failures.
Key Changes
notify_failurejob to the nightly workflow. This job is designed to create a new GitHub issue or update an existing one whenever a scheduled build fails.Why is this change being made?
notify_failurejob provides immediate visibility into regressions by automating issue creation.Tests
CI tests and https://github.com/AI-Hypercomputer/maxtext/actions/runs/25235820972
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.