Skip to content

[DECOUPLED-MODE] Add ICI parallelism decoupled logic to new tests#3404

Open
gulsumgudukbay wants to merge 1 commit intoAI-Hypercomputer:mainfrom
ROCm:mla-test-ici-parallelism
Open

[DECOUPLED-MODE] Add ICI parallelism decoupled logic to new tests#3404
gulsumgudukbay wants to merge 1 commit intoAI-Hypercomputer:mainfrom
ROCm:mla-test-ici-parallelism

Conversation

@gulsumgudukbay
Copy link
Collaborator

Description

Following tests were failing in decoupled mode, added ICI parallelism logic to them:

tests/unit/attention_test.py::MLATest::test_indexer_loss_kl_divergence_zero
tests/unit/attention_test.py::MLATest::test_indexer_loss

Tests

Ran tests, they are passing in decoupled mode

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gulsumgudukbay gulsumgudukbay self-assigned this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant