Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hengtaoguo
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Key Behaviors Tested:
Hugging Face Dataset Routing:
Verified that dataset names prefixed with "huggingface:" correctly trigger datasets.load_dataset.
Tested standard dataset loading as well as custom data slices using the data_files argument (e.g., loading specific .parquet files).
TFDS Dataset Routing: Verified that standard dataset names (e.g., "gsm8k") correctly fall back to tfds.data_source with the appropriate builder_kwargs.
Grain Pipeline Construction: Confirmed that regardless of the data source, the output is correctly passed into a grain data pipeline, ensuring the data is shuffled (using the configured seed) and mapped to the utils_rl.process_data function.
Directory Management: Added a check to ensure os.makedirs is called to create the data directory if it does not already exist.
Error Handling: Validated that a ValueError is strictly raised when dataset_name is None.
Debug Logging: Verified that accurate debug logs (including dataset size and split) are emitted when config.debug.rl is enabled.
FIXES: b/490411439
FIXES: b/490410907
FIXES: b/490411472
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.