Skip to content

Fix missing sft parameters across distill pipeline#3393

Draft
vlad-karp wants to merge 1 commit intomainfrom
vladk/sft-completion-fix3
Draft

Fix missing sft parameters across distill pipeline#3393
vlad-karp wants to merge 1 commit intomainfrom
vladk/sft-completion-fix3

Conversation

@vlad-karp
Copy link
Collaborator

Description

The most recent refactoring of the distill pipeline which combined teacher and student model calls into a single jitted function left some of the sft mode input parameters missing in the distill pipeline.
This is a fix to bring them back

Tests

The same as in #3332.
We probably need a dedicated sft test but that would require refactoring train_distill() to extract labels_fn() to be used for testing.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../trainers/post_train/distillation/train_distill.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant