Open
Conversation
cda70e4 to
820a729
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
40118d2 to
e86792c
Compare
Create unit tests for check_answer formatting
e86792c to
f6eb69b
Compare
hengtaoguo
approved these changes
Mar 10, 2026
| responses=[ | ||
| "<reasoning>Need to use <reasoning> and </reasoning>, " | ||
| "<answer> and </answer></reasoning><answer>11/3</answer>" | ||
| "<reasoning>Need to use <reasoning> and </reasoning>, " "<answer> and </answer></reasoning><answer>11/3</answer>" |
Collaborator
There was a problem hiding this comment.
You may need to reformat this file because of the pyink error.
Try pyink --pyink-indentation=2 --line-length=122 ., only keep the changes in rl_utils_test.py and revert the others for now.
NuojCheng
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for check_answer to cover the following cases:
Tests
pytest -rs tests/unit/rl_utils_test.py passes
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.