Conversation
| - all | ||
| - tpu | ||
| - gpu | ||
| for_dev_test: |
There was a problem hiding this comment.
What is the use case for this?
There was a problem hiding this comment.
This is to keep the images generated by this workflow development tests in another image repo so the formal image repo is not polluted.
(our previous discussion: For testing purposes, can you change the name of the docker image so that it doesn't pollute our production images.)
ffd00f3 to
ea56990
Compare
| context: . | ||
| file: ${{ inputs.dockerfile }} | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:latest | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:${{ inputs.image_date }}-build-${{ github.run_id }} |
There was a problem hiding this comment.
@SurbhiJainUSC we need to discuss what tags do we want to add to the images before and after testing.
Current:
- before tests: ${{ github.run_id }}, and hashes of the repos
- after tests: "latest", and "<image_date>"
3b2089d to
8ca7650
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
be50e5b to
71076a6
Compare
There was a problem hiding this comment.
Why do we need a different workflow for testing the docker image?
Can we update build_and_push_docker_image.yml to something like this:
# https://github.com/AI-Hypercomputer/maxtext/blob/main/.github/workflows/build_and_push_docker_image.yml#L111
- name: Build and push Docker image
# Runs tests on docker image with tag as ${{ github.run_id }}
- name: Test Dokcer Image
# [Add tags such as ](https://github.com/AI-Hypercomputer/maxtext/blob/main/.github/workflows/build_and_push_docker_image.yml#L129)
- name: Add tags to Docker Image
There was a problem hiding this comment.
Merged the jobs into build_and_push_docker_image.yml and now tests are executed immediately after the image has been pushed.
One caveat: since the tpu-post-training-nightly depends on tpu-post-training-stable, the whole workflow needs more time to finish because it now waits for the test to be done.
- images will only be tagged to the current date when unit tests pass - images will only be tagged to "latest" when unit tests pass
Description
Tests
See this manually triggered workflow run
Old:
Another old workflow run - by calling tests from another file.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.