Open
Conversation
syhuang22
force-pushed
the
ltx2/refactor_encoder
branch
2 times, most recently
from
a41a80d to
1f3b235
Compare
mbohlool
requested changes
Mar 12, 2026
|
|
||
| # Padding has been filled with valid register tokens. The entire sequence | ||
| # must now be attended to, so we clear the mask. | ||
| new_mask = None |
Collaborator
There was a problem hiding this comment.
nit: just return output, None? instead of declaring a new variable.
| audio_connector_num_attention_heads: int = 30, | ||
| audio_connector_num_layers: int = 2, | ||
| audio_connector_num_learnable_registers: int = 128, | ||
| connector_rope_base_seq_len: int = 4096, |
Collaborator
There was a problem hiding this comment.
this new parameter is not used?! did you forget passing it to the connector?
Collaborator
Author
There was a problem hiding this comment.
Yes this should pass to the connector
syhuang22
force-pushed
the
ltx2/refactor_encoder
branch
from
1f3b235 to
8a57774
Compare
…beddingsProcessor; move tests to tests/ltx2/ Signed-off-by: James Huang <syhuang1201@gmail.com>
syhuang22
force-pushed
the
ltx2/refactor_encoder
branch
from
8a57774 to
0bb0067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some LTX2 updates on text encoder, this pr aims to follow that changes