Optimized Matrix Multiplication and Validation Logic#2
Open
BehrozKarim wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naive_matmul: This function is the naive textbooki -> j -> ktriple loop with a local sum accumulator.blocked_matmul: six-loop tile structure withblock_size = 32. Inside each tile, inner loops usei -> k -> jinstead of the pseudocode'si -> j -> k. This makes the innermost loop access B and C with stride 1, allowing the hardware prefetcher and the compiler's auto-vectorizer to work.std::min(...)handles non-multiple-of-block-size dimensions; C is zero-initialized because each tile accumulates into it.parallel_matmul:#pragma omp parallel forover the outer i loop. Each thread zeros and then fills a disjoint set of rows of C (so no atomics or reductions are needed), using the samei -> k -> jinner ordering.We came up with the
i->k->jinner ordering trick because we were not achieving any speedups with the pseudocode version of the implementation.