Skip to content

[codex] Improve dev dashboard workflow and docs#293

Merged
michaelmwu merged 6 commits into
mainfrom
michaelmwu/tanstack-dev-errors
May 20, 2026
Merged

[codex] Improve dev dashboard workflow and docs#293
michaelmwu merged 6 commits into
mainfrom
michaelmwu/tanstack-dev-errors

Conversation

@michaelmwu
Copy link
Copy Markdown
Member

@michaelmwu michaelmwu commented May 19, 2026

Summary

  • add a development-only dashboard error diagnostics panel for caught API failures, uncaught browser errors, and unhandled promise rejections
  • expand that panel with always-visible endpoint, status text, route/view, detail/error fields, payload, and stack context
  • show friendlier dashboard copy for historical roster lookup failures instead of bare error codes like person_not_found
  • add ./scripts/dev.sh no-bot / web-worker for infra + migrations + Web/API dashboard + worker without launching the Discord bot
  • add ./scripts/dev.sh login to create local/dev one-time dashboard links without running the Discord bot
  • rewrite README.md as an overview and quickstart
  • move detailed development workflow into DEVELOPMENT.md, architecture into ARCHITECTURE.md, and configuration notes into docs/configuration.md
  • include the intentional discord agent eval harness wording update
  • rebuild the checked-in Vite dashboard bundle served by FastAPI

Review follow-up

  • restored backward-compatible defaults for scripts/dev_mux.py helper tests after CI caught the signature change
  • addressed attached review comments: dynamic dev mux usage name, web-worker help text, and blank-string error fallback handling

Validation

  • uv run pytest tests/unit/test_backend_api.py -k historical_member
  • uv run pytest tests/unit/test_dev_mux.py tests/unit/test_backend_api.py -k "dev_mux or historical_member"
  • uv run ruff check scripts/dev_mux.py apps/api/src/five08/backend/api.py tests/unit/test_backend_api.py
  • python3 -m py_compile scripts/dev_mux.py
  • sh -n scripts/dev.sh
  • bun run format
  • bun run lint
  • bun run typecheck
  • bun run test
  • bun run build
  • ./scripts/dev.sh login mock-server smoke test
  • GitHub PR checks are passing on run 26136833735

Copilot AI review requested due to automatic review settings May 19, 2026 22:35
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@michaelmwu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 29 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 086abfe2-d213-489e-a729-39a5a31c4c90

📥 Commits

Reviewing files that changed from the base of the PR and between 2ad2b92 and 9f7a449.

📒 Files selected for processing (16)
  • ARCHITECTURE.md
  • DEVELOPMENT.md
  • README.md
  • apps/admin_dashboard/src/main.tsx
  • apps/api/src/five08/backend/api.py
  • apps/api/src/five08/backend/static/dashboard/.vite/manifest.json
  • apps/api/src/five08/backend/static/dashboard/assets/index-617IyoY5.js
  • apps/api/src/five08/backend/static/dashboard/assets/index-CIisEPpj.css
  • apps/api/src/five08/backend/static/dashboard/assets/index-Cjc8hvil.css
  • apps/api/src/five08/backend/static/dashboard/assets/index-WxptdPpM.js
  • apps/api/src/five08/backend/static/dashboard/index.html
  • docs/configuration.md
  • docs/discord-agent-eval-harness.md
  • scripts/dev.sh
  • scripts/dev_mux.py
  • tests/unit/test_backend_api.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch michaelmwu/tanstack-dev-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds development-only error diagnostics to the admin dashboard UI and rebuilds the checked-in static dashboard bundle served by the API so developers can see richer context for API failures and browser-level errors while production behavior stays unchanged.

Changes:

  • Introduces a dev-only on-page diagnostics panel that captures caught API request failures, uncaught browser errors, and unhandled promise rejections.
  • Enhances request error handling with an ApiRequestError that includes method/URL/status/payload for better debugging context.
  • Updates the checked-in Vite build output (HTML manifest + hashed CSS/JS references).

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/admin_dashboard/src/main.tsx Adds ApiRequestError, centralized showError, global error listeners, and a dev-only diagnostics panel UI.
apps/api/src/five08/backend/static/dashboard/index.html Updates asset references to the newly built hashed JS/CSS filenames.
apps/api/src/five08/backend/static/dashboard/.vite/manifest.json Updates Vite manifest entries to point at the new hashed assets.
apps/api/src/five08/backend/static/dashboard/assets/index-UBE2QwKH.css Adds the newly built hashed CSS bundle.
apps/api/src/five08/backend/static/dashboard/assets/index-Cjc8hvil.css Removes the previous hashed CSS bundle.
Files not reviewed (1)
  • apps/api/src/five08/backend/static/dashboard/assets/index-UBE2QwKH.css: Language not supported
Comments suppressed due to low confidence (1)

apps/admin_dashboard/src/main.tsx:1993

  • This panel can display non-request errors (uncaught browser errors / unhandled promise rejections), but the heading always says "Request failed". Consider using more general copy (e.g., "Dashboard error") or switching the heading based on whether request context (method/url/status) is available.
          <div className="flex flex-wrap items-center gap-2">
            <strong className="text-red-300">Request failed</strong>
            <Badge variant="failed">{status || latest.name || "Error"}</Badge>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/admin_dashboard/src/main.tsx Outdated
Comment thread apps/admin_dashboard/src/main.tsx Outdated
Comment on lines +1985 to +1987
<aside
aria-label="Development request errors"
className="fixed bottom-5 left-5 z-50 grid max-h-[70vh] w-[min(42rem,calc(100vw-2.5rem))] gap-3 overflow-auto rounded-md border border-red-500/40 bg-background p-4 text-sm shadow-2xl"
@michaelmwu michaelmwu changed the title [codex] Add dev dashboard error diagnostics [codex] Add dev dashboard diagnostics and no-bot stack command May 20, 2026
Copilot AI review requested due to automatic review settings May 20, 2026 01:55
@michaelmwu michaelmwu changed the title [codex] Add dev dashboard diagnostics and no-bot stack command [codex] Improve dev dashboard workflow and docs May 20, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • apps/api/src/five08/backend/static/dashboard/assets/index-UBE2QwKH.css: Language not supported

Comment thread scripts/dev_mux.py
Comment thread scripts/dev.sh Outdated
Copilot AI review requested due to automatic review settings May 20, 2026 02:05
@michaelmwu michaelmwu merged commit d1055d3 into main May 20, 2026
11 checks passed
@michaelmwu michaelmwu deleted the michaelmwu/tanstack-dev-errors branch May 20, 2026 02:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • apps/api/src/five08/backend/static/dashboard/assets/index-CIisEPpj.css: Language not supported

Comment on lines +2755 to +2765
elif exc.code == "candidate_not_found":
detail = (
"The selected person record is no longer available. Search again and "
"choose one of the current matches."
)
elif exc.code == "ambiguous_person":
detail = (
f'Multiple people matched "{person}". Choose the matching person record.'
)
else:
detail = "Unable to resolve that person for the historical roster."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants