Skip to content

fix invalid usage of == operator#465

Open
saschaszott wants to merge 5 commits into4Science:main-crisfrom
saschaszott:patch-42
Open

fix invalid usage of == operator#465
saschaszott wants to merge 5 commits into4Science:main-crisfrom
saschaszott:patch-42

Conversation

@saschaszott
Copy link

Description

This fix is inspired by the finding mentioned in a comment of Github issue DSpace/dspace-angular#2004 (comment)

@saschaszott
Copy link
Author

@jor4science, this is not production-critical but easy to merge.

@jor4science
Copy link

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott .
Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@saschaszott
Copy link
Author

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott . Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@jor4science , could you clarify how this would work? The PRs affect both the Angular frontend and the Java backend.

@jpiscanc
Copy link

@jor4science, this is not production-critical but easy to merge.

Thanks @saschaszott . Could you collect this PR with other PR: AccountServiceImpl : resolve merge conflicts in Javadoc comments #484 , added German translations #39, add missing translation keys #28, SCSS cleanup: remove duplicated SCSS variables #107, remove console.log in ngOnInit #111 together in a single "clean-up-patch" so that is easier for us to quickly work and integrate all this PR in the next release.

@jor4science , could you clarify how this would work? The PRs affect both the Angular frontend and the Java backend.
You're right. My fault. Obviously collect Java backend:
this PR with AccountServiceImpl : resolve merge conflicts in Javadoc comments #484

I'm adding the comment on Angular added German translations #39 side.
Thanks

@saschaszott
Copy link
Author

saschaszott commented Mar 14, 2025

@jor4science : done (backend part)

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants