Skip to content

perf: Return the obtained chat_record #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangliang181230 wants to merge 1 commit into
base: v2
Choose a base branch
from
+3 −2
Open

perf: Return the obtained chat_record #5184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/chat/serializers/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,9 @@ def get_chat_record(chat_info, chat_record_id):
return chat_record_list[-1]
chat_record = QuerySet(ChatRecord).filter(id=chat_record_id, chat_id=chat_info.chat_id).first()
if chat_record is None:
if not is_valid_uuid(chat_record_id):
raise ChatException(500, _("Conversation record does not exist"))
Copy link
Copy Markdown
Contributor Author

@wangliang181230 wangliang181230 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要校验id的格式，理论上记录不存在就应该直接抛出异常。和ID的格式无关才对。

raise ChatException(500, _("Conversation record does not exist"))
else:
return chat_record
chat_record = QuerySet(ChatRecord).filter(id=chat_record_id).first()
return chat_record

Expand Down
Loading