Skip to content

feat: change default condition from AND(All) to OR(Any)#4866

Closed
wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
wangliang181230:patch-1
Closed

feat: change default condition from AND(All) to OR(Any)#4866
wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
wangliang181230:patch-1

Conversation

@wangliang181230
Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 12, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangliang181230 wangliang181230 changed the title feat: change default condition from 'AND' to 'OR' feat: change default condition from AND(All) to OR(Any) Mar 12, 2026
@shaohuzhang1
Copy link
Copy Markdown
Contributor

感谢你的 PR 和付出的时间!
这个改动主要是针对某个特定使用场景,而当前项目希望保持对更广泛用户的通用支持。
为了避免增加维护成本,我们暂时不会合并这个实现,所以先关闭这个 PR。

如果以后能提供一个更通用或可配置的方案,我们非常欢迎再次提交。

@wangliang181230 wangliang181230 deleted the patch-1 branch March 16, 2026 02:47
@wangliang181230
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 加了配置化了,还是被你们关闭了,哎。 #5019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants