Skip to content

fix: [Trigger] When the request parameters triggered by an event are not mandatory, failing to pass the event parameters results in validation errors and request failure. #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Feb 2, 2026
+5 −1
Merged

fix: [Trigger] When the request parameters triggered by an event are not mandatory, failing to pass the event parameters results in validation errors and request failure. #4748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/trigger/handler/impl/trigger/event_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ def get_parameters(body_setting, request: Request):
parameters = {}
for body in body_setting:
value = request.data.get(body.get('field'))
if value is None and body.get('required'):
required = body.get('required')
if value is None and required:
raise AppApiException(500, f'{body.get("desc")} is required')
if value is None and not required:
parameters[body.get('field')] = None
continue
_type = body.get('type')
valid_parameter_type(value, _type, body.get("desc"))
parameters[body.get('field')] = value
Expand Down