feat: change feishu channel logic#12465
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3adb88da5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| result.GroupAllowFrom = extractStringList(feishu["groupAllowFrom"]) | ||
| defaultBot := defaultFeishuBot() | ||
| defaultBot.Enabled = extractBoolValue(feishu["enabled"], defaultBot.Enabled) |
There was a problem hiding this comment.
This assignment changes defaultBot.Enabled to depend only on feishu["enabled"], but older saved Feishu configs stored the default bot’s enabled flag under accounts.default.enabled while feishu.enabled represented the overall channel state. In configs where the default bot was disabled and another account was enabled, this now reloads the default bot as enabled and a subsequent save will silently turn it back on. Preserve backward compatibility by falling back to defaultAccount["enabled"] when it exists.
Useful? React with 👍 / 👎.
3 participants
No description provided.