From 013a1c8ba78f268239e22372708664e3e0ea8770 Mon Sep 17 00:00:00 2001 From: Brendan Collins Date: Sat, 20 Jun 2026 02:50:30 -0700 Subject: [PATCH 1/2] classify: remove unused import and fix isort ordering Remove the unused not_implemented_func import (flake8 F401) and reorder the import block so isort passes under the setup.cfg config (cmath into the stdlib group, dataset_support before utils). No behavioural change. --- xrspatial/classify.py | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/xrspatial/classify.py b/xrspatial/classify.py index 8144a4afa..660fdefd4 100644 --- a/xrspatial/classify.py +++ b/xrspatial/classify.py @@ -1,11 +1,10 @@ from __future__ import annotations +import cmath import warnings from functools import partial from typing import List, Optional -import cmath - import xarray as xr try: @@ -24,16 +23,9 @@ class cupy(object): import numba as nb import numpy as np -from xrspatial.utils import ( - ArrayTypeFunctionMapping, - _dask_task_name_kwargs, - _validate_raster, - _validate_scalar, - cuda_args, - ngjit, - not_implemented_func, -) from xrspatial.dataset_support import supports_dataset +from xrspatial.utils import (ArrayTypeFunctionMapping, _dask_task_name_kwargs, _validate_raster, + _validate_scalar, cuda_args, ngjit) def _available_memory_bytes(): From e7c437ba3be9e4903051bc680265120aefc21a08 Mon Sep 17 00:00:00 2001 From: Brendan Collins Date: Sat, 20 Jun 2026 02:50:52 -0700 Subject: [PATCH 2/2] sweep-style: record classify inspection (issue #3402) --- .claude/sweep-style-state.csv | 1 + 1 file changed, 1 insertion(+) diff --git a/.claude/sweep-style-state.csv b/.claude/sweep-style-state.csv index 34775463d..dd337141f 100644 --- a/.claude/sweep-style-state.csv +++ b/.claude/sweep-style-state.csv @@ -1,5 +1,6 @@ module,last_inspected,issue,severity_max,categories_found,notes aspect,2026-05-29,2683,MEDIUM,1,E402+E305 line 38: from xrspatial.geodesic import block sat below _geodesic_cuda_dims; moved up with top-of-file imports. E501 lines 219/263: wrapped two _run_gpu_geodesic_aspect kernel-launch calls (101/109 chars). Cat 4 isort reviewed but NOT applied: slope.py/curvature.py use one-import-per-line for xrspatial.utils so raw isort would make aspect inconsistent. Cat 2/3/5 grep clean. PR #2740. 82 aspect+geodesic tests pass. +classify,2026-06-20,3402,HIGH,3;4,"F401 unused not_implemented_func import; isort ordering (cmath group, dataset_support before utils). No Cat 1/2/5. Fixed in rockout PR." contour,2026-05-29,2698,HIGH,3,"F821 line 557: contours() return annotation ""gpd.GeoDataFrame"" referenced gpd not bound at module scope (only imported inside _to_geopandas). Fixed via TYPE_CHECKING-guarded import geopandas as gpd, matching polygonize.py. No runtime change; geopandas stays optional. isort clean. Cat 1/2/4/5 clean. 24 contour tests pass. PR open." cost_distance,2026-06-15,3339,HIGH,1;3;4;5,"Cat 3 F401: removed unused 'from functools import partial' (L32, refactor leftover, not re-exported). Cat 5 mutable default target_values: list = [] was found here too, but the parallel api-consistency PR #3348 fixed it first (same None-sentinel normalization, merged to main); on reconciliation this PR's duplicate source change and its two target_values tests were dropped, so PR #3350 is now lint-only. Cat 1: E302 L63 (1->2 blank lines before @ngjit _heap_push; placed blanks between comment divider and decorator to satisfy both E302 and isort) + E127 x5 (_cost_distance_dask_cupy L461-462, _cost_distance_dask_iterative L1005-1007 signature continuation over-indent). Cat 4 isort: dataset_support before utils, utils from-import reflowed to 100 cols. Cat 2 grep clean. flake8+isort clean on module after fix; cost_distance tests pass (CUDA available). Pre-existing test-file lint (F401 L314/L504, E201 L449, isort drift) left untouched - out of module scope. PR open." fire,2026-06-19,3395,HIGH,3;4,Cat3 F401 math.log unused + F841 S_T unused local; Cat4 isort utils import reorder. No Cat1/2/5. Fixed in #3395 rockout.