Skip to content

Custom scalar types already resolved through webonyx/graphql #733

@deeky666

Description

@deeky666

Hi,

I recently made an observation that ScalarType::parseValue() is called twice for custom scalars.

This is due to webonyx/graphql already resolving ScalarType and EnumType by itself while GraphQLite is trying to resolve it again. Obviously this observation already has been made for Enums but not for Scalars:

GraphQL\Utils\Value

Image

TheCodingMachine\GraphQLite\Types\ArgumentResolver

Image

I guess the second resolve call can be omitted then if we have a ScalarType :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions