Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates ToolHive documentation for v0.19.0, covering new features (webhook authorization, multi-client skill install, shared telemetry refs) and documenting breaking field/flag renames (e.g., remoteUrl, externalAuthConfigRef, --clients).
Changes:
- Add a new CLI guide documenting webhook-based authorization middleware and update the sidebar to include it.
- Update Kubernetes operator docs to use
remoteUrland to prefertelemetryConfigRef(with deprecation notes for inline telemetry). - Update CLI docs for multi-client skill installation (
--clients) and refresh client compatibility (Cursor skills support).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sidebars.ts | Adds the new webhooks guide to the “Advanced workflows” sidebar section. |
| docs/toolhive/reference/client-compatibility.mdx | Updates Cursor to show skills support as supported. |
| docs/toolhive/guides-vmcp/authentication.mdx | Updates vMCP auth examples to use externalAuthConfigRef enum value. |
| docs/toolhive/guides-k8s/telemetry-and-metrics.mdx | Documents telemetryConfigRef usage for both MCPServer and MCPRemoteProxy and expands deprecation notice. |
| docs/toolhive/guides-k8s/remote-mcp-proxy.mdx | Renames remoteURL → remoteUrl across examples and updates telemetry guidance to prefer shared configs. |
| docs/toolhive/guides-cli/webhooks.mdx | New guide describing webhook authorization configuration, usage, and request/response formats. |
| docs/toolhive/guides-cli/skills-management.mdx | Updates skill install docs to use --clients and documents installing to multiple clients (incl. Cursor paths). |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@claude can you review if the comments were addressed? |
|
Claude finished @reyortiz3's task in 55s —— View job Review: were the Copilot comments addressed?
Comment 1 —
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@claude can you review again if all the changes were fixed? |
|
Claude finished @reyortiz3's task in 1m 5s —— View job Re-review: are all changes fixed?
|
Editorial reviewScope: 7 files changed (1 new, 6 modified). Breaking changes ( Prior review status: Both Copilot review comments are resolved. Primary issues1. Missing mutating webhook response format (webhooks.mdx) The page describes both mutating and validating webhooks, but only documents the response format for validating webhooks. Readers implementing a mutating webhook need to know what the response looks like - does it return the mutated 2. Prometheus metrics list sits under the deprecated section (remote-mcp-proxy.mdx) The metrics list ( Secondary issues
What looks good
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix JSON Patch example path from /params/context to /mcp_request/params/context (required by middleware) - Note that hmac_secret_ref is not yet implemented upstream Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@claude can you review again if all the comments have been addressed? |
|
Claude finished @reyortiz3's task in 1m 8s —— View job Re-review: are all comments addressed?
All comments — both Copilot review comments and danbarr's editorial review — have been addressed. Copilot review commentsBoth previously confirmed resolved. Still resolved. danbarr's editorial review — Primary issues1. Missing mutating webhook response format (webhooks.mdx) Status: ✅ Addressed A full "Mutating webhook response format" section was added (lines 198–233). It documents:
2. Prometheus metrics list under deprecated section (remote-mcp-proxy.mdx) Status: ✅ Addressed The metrics list ( danbarr's editorial review — Secondary issues3. "Target a specific client" mention of comma-separated list (skills-management.mdx ~line 116) Status: ✅ Addressed The section now reads simply "use the 4. Em dashes in webhooks.mdx (original lines 12, 30, 32, 138, 139) Status: ✅ Addressed All em dashes have been rephrased naturally:
Summary: All editorial and Copilot review comments are fully resolved. The PR is ready for final approval. |

Summary
v0.19.0tagChanges
Breaking changes documented
remoteUrlfield rename (MCPRemoteProxy,MCPServerEntry): Updated all YAML examples inremote-mcp-proxy.mdxfromremoteURL:toremoteUrl:(10 occurrences)externalAuthConfigRefenum value: Updated all vMCP authentication examples from deprecatedtype: external_auth_config_reftotype: externalAuthConfigRef--clientsflag: Updatedskills-management.mdxto reflect thatthv skill installnow uses--clients(plural, comma-separated) instead of--clientNew features documented
client-compatibility.mdx— Cursor skills column ❌ → ✅--clients claude-code,cursorand--clients allwith atomic rollback behaviorMCPRemoteProxytelemetry config ref: Updatedremote-mcp-proxy.mdxandtelemetry-and-metrics.mdxto showtelemetryConfigRefonMCPRemoteProxy(inlinetelemetry:marked deprecated)guides-cli/webhooks.mdxcovering--webhook-configflag, YAML/JSON config format, failure policies, and request/response formats; added to sidebar under Advanced workflowsNeeds follow-up (auto-generated files)
docs/toolhive/reference/cli/thv_skill_install.md— still shows old--client stringflag; needs regeneration from CLI sourcedocs/toolhive/reference/crd-spec.md— needs regeneration fortelemetryConfigRefonMCPRemoteProxy,remoteUrl/externalUrlJSON tag renames, andenforceServersremoval fromMCPRegistryTest plan
npm run prettier— passes (all files)npm run eslint— passes (all changed MDX/TS files)mcp-metadata-pluginfetch failure unrelated to these changes🤖 Generated with Claude Code