adapted load balancers list command to return valid json/yaml for empty api responses

Author: j1n-o9r

internal/cmd/load-balancer/list/list.go

@@ -67,23 +67,20 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 				return fmt.Errorf("get load balancers: %w", err)
 			}
 
-			if resp.LoadBalancers == nil || (resp.LoadBalancers != nil && len(*resp.LoadBalancers) == 0) {
-				projectLabel, err := projectname.GetProjectName(ctx, params.Printer, params.CliVersion, cmd)
-				if err != nil {
-					params.Printer.Debug(print.ErrorLevel, "get project name: %v", err)
-					projectLabel = model.ProjectId
-				}
-				params.Printer.Info("No load balancers found for project %q\n", projectLabel)
-				return nil
+			loadBalancers := utils.GetSliceFromPointer(resp.LoadBalancers)
+
+			projectLabel, err := projectname.GetProjectName(ctx, params.Printer, params.CliVersion, cmd)
+			if err != nil {
+				params.Printer.Debug(print.ErrorLevel, "get project name: %v", err)
+				projectLabel = model.ProjectId
 			}
 
-			loadBalancers := *resp.LoadBalancers
 			// Truncate output
 			if model.Limit != nil && len(loadBalancers) > int(*model.Limit) {
 				loadBalancers = loadBalancers[:*model.Limit]
 			}
 
-			return outputResult(params.Printer, model.OutputFormat, loadBalancers)
+			return outputResult(params.Printer, model.OutputFormat, projectLabel, loadBalancers)
 		},
 	}
 
@@ -123,8 +120,12 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *loadbalance
 	return req
 }
 
-func outputResult(p *print.Printer, outputFormat string, loadBalancers []loadbalancer.LoadBalancer) error {
+func outputResult(p *print.Printer, outputFormat, projectLabel string, loadBalancers []loadbalancer.LoadBalancer) error {
 	return p.OutputResult(outputFormat, loadBalancers, func() error {
+		if len(loadBalancers) == 0 {
+			p.Outputf("No load balancers found for project %q\n", projectLabel)
+			return nil
+		}
 		table := tables.NewTable()
 		table.SetHeader("NAME", "STATE", "IP ADDRESS", "LISTENERS", "TARGET POOLS")
 		for i := range loadBalancers {

internal/cmd/load-balancer/list/list_test.go

@@ -155,6 +155,7 @@ func TestBuildRequest(t *testing.T) {
 func TestOutputResult(t *testing.T) {
 	type args struct {
 		outputFormat  string
+		projectLabel  string
 		loadBalancers []loadbalancer.LoadBalancer
 	}
 	tests := []struct {
@@ -185,7 +186,7 @@ func TestOutputResult(t *testing.T) {
 	params := testparams.NewTestParams()
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if err := outputResult(params.Printer, tt.args.outputFormat, tt.args.loadBalancers); (err != nil) != tt.wantErr {
+			if err := outputResult(params.Printer, tt.args.outputFormat, tt.args.projectLabel, tt.args.loadBalancers); (err != nil) != tt.wantErr {
 				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})