|
| 1 | +/** |
| 2 | + * @vitest-environment node |
| 3 | + */ |
| 4 | +import { authMockFns, dbChainMock, dbChainMockFns, resetDbChainMock } from '@sim/testing' |
| 5 | +import { NextRequest } from 'next/server' |
| 6 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 7 | + |
| 8 | +// Override global db mock with the configurable chain mock |
| 9 | +vi.mock('@sim/db', () => dbChainMock) |
| 10 | + |
| 11 | +const { mockValidateWorkflowAccess, mockGetWorkspaceBilledAccountUserId } = vi.hoisted(() => ({ |
| 12 | + mockValidateWorkflowAccess: vi.fn(), |
| 13 | + mockGetWorkspaceBilledAccountUserId: vi.fn(), |
| 14 | +})) |
| 15 | + |
| 16 | +vi.mock('@/app/api/workflows/middleware', () => ({ |
| 17 | + validateWorkflowAccess: mockValidateWorkflowAccess, |
| 18 | +})) |
| 19 | + |
| 20 | +vi.mock('@/lib/workspaces/utils', () => ({ |
| 21 | + getWorkspaceBilledAccountUserId: mockGetWorkspaceBilledAccountUserId, |
| 22 | +})) |
| 23 | + |
| 24 | +vi.mock('@/lib/logs/execution/logging-session', () => ({ |
| 25 | + LoggingSession: vi.fn().mockImplementation(() => ({ |
| 26 | + start: vi.fn().mockResolvedValue(undefined), |
| 27 | + markAsFailed: vi.fn().mockResolvedValue(undefined), |
| 28 | + safeCompleteWithError: vi.fn().mockResolvedValue(undefined), |
| 29 | + safeComplete: vi.fn().mockResolvedValue(undefined), |
| 30 | + })), |
| 31 | +})) |
| 32 | + |
| 33 | +vi.mock('@/lib/logs/execution/trace-spans/trace-spans', () => ({ |
| 34 | + buildTraceSpans: vi.fn().mockReturnValue([]), |
| 35 | +})) |
| 36 | + |
| 37 | +import { POST } from './route' |
| 38 | + |
| 39 | +const makeRequest = (workflowId: string, body: unknown) => |
| 40 | + new NextRequest(`http://localhost/api/workflows/${workflowId}/log`, { |
| 41 | + method: 'POST', |
| 42 | + headers: { 'Content-Type': 'application/json' }, |
| 43 | + body: JSON.stringify(body), |
| 44 | + }) |
| 45 | + |
| 46 | +const validResult = { success: true, output: { value: 42 } } |
| 47 | + |
| 48 | +describe('POST /api/workflows/[id]/log cross-tenant guard', () => { |
| 49 | + const OWNER_WORKFLOW_ID = 'wf-owner' |
| 50 | + const ATTACKER_WORKFLOW_ID = 'wf-attacker' |
| 51 | + const VICTIM_EXECUTION_ID = 'exec-victim-uuid' |
| 52 | + |
| 53 | + beforeEach(() => { |
| 54 | + vi.clearAllMocks() |
| 55 | + resetDbChainMock() |
| 56 | + authMockFns.mockGetSession.mockResolvedValue({ user: { id: 'user-1' } }) |
| 57 | + mockValidateWorkflowAccess.mockResolvedValue({ error: null }) |
| 58 | + mockGetWorkspaceBilledAccountUserId.mockResolvedValue('user-1') |
| 59 | + // Default: no existing log (fresh execution) |
| 60 | + dbChainMockFns.limit.mockResolvedValue([]) |
| 61 | + }) |
| 62 | + |
| 63 | + it('returns 404 when executionId belongs to a different workflow', async () => { |
| 64 | + dbChainMockFns.limit.mockResolvedValueOnce([{ workflowId: OWNER_WORKFLOW_ID }]) |
| 65 | + |
| 66 | + const res = await POST( |
| 67 | + makeRequest(ATTACKER_WORKFLOW_ID, { |
| 68 | + executionId: VICTIM_EXECUTION_ID, |
| 69 | + result: validResult, |
| 70 | + }), |
| 71 | + { params: Promise.resolve({ id: ATTACKER_WORKFLOW_ID }) } |
| 72 | + ) |
| 73 | + |
| 74 | + expect(res.status).toBe(404) |
| 75 | + const body = await res.json() |
| 76 | + expect(body.error).toBe('Execution not found') |
| 77 | + }) |
| 78 | + |
| 79 | + it('proceeds when executionId belongs to the same workflow', async () => { |
| 80 | + dbChainMockFns.limit.mockResolvedValueOnce([{ workflowId: OWNER_WORKFLOW_ID }]) |
| 81 | + |
| 82 | + const res = await POST( |
| 83 | + makeRequest(OWNER_WORKFLOW_ID, { |
| 84 | + executionId: VICTIM_EXECUTION_ID, |
| 85 | + result: validResult, |
| 86 | + }), |
| 87 | + { params: Promise.resolve({ id: OWNER_WORKFLOW_ID }) } |
| 88 | + ) |
| 89 | + |
| 90 | + expect(res.status).not.toBe(404) |
| 91 | + expect(res.status).not.toBe(403) |
| 92 | + }) |
| 93 | + |
| 94 | + it('proceeds when executionId has no existing log row (fresh execution)', async () => { |
| 95 | + dbChainMockFns.limit.mockResolvedValueOnce([]) |
| 96 | + |
| 97 | + const res = await POST( |
| 98 | + makeRequest(OWNER_WORKFLOW_ID, { |
| 99 | + executionId: 'brand-new-execution-id', |
| 100 | + result: validResult, |
| 101 | + }), |
| 102 | + { params: Promise.resolve({ id: OWNER_WORKFLOW_ID }) } |
| 103 | + ) |
| 104 | + |
| 105 | + expect(res.status).not.toBe(404) |
| 106 | + expect(res.status).not.toBe(403) |
| 107 | + }) |
| 108 | +}) |
0 commit comments