fix: avoid forced async selector refetch on open

Danigm-dev · Danigm-dev · commit c0cd00aa73e9 · 2026-04-07T15:00:09.000+02:00
diff --git a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx
@@ -473,10 +473,10 @@ export const ComboBox = memo(function ComboBox({
   const handleOpenChange = useCallback(
     (open: boolean) => {
       if (open) {
-        void fetchOptionsIfNeeded(true)
+        void fetchOptionsIfNeeded(Boolean(fetchError))
       }
     },
-    [fetchOptionsIfNeeded]
+    [fetchOptionsIfNeeded, fetchError]
   )
 
   /**
diff --git a/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx b/apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx
@@ -214,10 +214,10 @@ export const Dropdown = memo(function Dropdown({
   const handleOpenChange = useCallback(
     (open: boolean) => {
       if (open) {
-        void fetchOptionsIfNeeded(true)
+        void fetchOptionsIfNeeded(Boolean(fetchError))
       }
     },
-    [fetchOptionsIfNeeded]
+    [fetchOptionsIfNeeded, fetchError]
   )
 
   const evaluatedOptions = useMemo(() => {

Original file line number	Diff line number	Diff line change
`@@ -473,10 +473,10 @@ export const ComboBox = memo(function ComboBox({`
`473`	`473`	`const handleOpenChange = useCallback(`
`474`	`474`	`(open: boolean) => {`
`475`	`475`	`if (open) {`
`476`		`- void fetchOptionsIfNeeded(true)`
	`476`	`+ void fetchOptionsIfNeeded(Boolean(fetchError))`
`477`	`477`	`}`
`478`	`478`	`},`
`479`		`- [fetchOptionsIfNeeded]`
	`479`	`+ [fetchOptionsIfNeeded, fetchError]`
`480`	`480`	`)`
`481`	`481`
`482`	`482`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -214,10 +214,10 @@ export const Dropdown = memo(function Dropdown({`
`214`	`214`	`const handleOpenChange = useCallback(`
`215`	`215`	`(open: boolean) => {`
`216`	`216`	`if (open) {`
`217`		`- void fetchOptionsIfNeeded(true)`
	`217`	`+ void fetchOptionsIfNeeded(Boolean(fetchError))`
`218`	`218`	`}`
`219`	`219`	`},`
`220`		`- [fetchOptionsIfNeeded]`
	`220`	`+ [fetchOptionsIfNeeded, fetchError]`
`221`	`221`	`)`
`222`	`222`
`223`	`223`	`const evaluatedOptions = useMemo(() => {`