fix(agiloft): address PR review feedback

- Add HTTPS enforcement guard to agiloftLogin to prevent plaintext credential transit
- Add null guard on data.output in attach_file transformResponse
- Change empty AgiloftSavedSearchParams interface to type alias

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/tools/agiloft/attach_file.ts

@@ -103,10 +103,10 @@ export const agiloftAttachFileTool: ToolConfig<AgiloftAttachFileParams, AgiloftA
       return {
         success: true,
         output: {
-          recordId: data.output.recordId ?? '',
-          fieldName: data.output.fieldName ?? '',
-          fileName: data.output.fileName ?? '',
-          totalAttachments: data.output.totalAttachments ?? 0,
+          recordId: data.output?.recordId ?? '',
+          fieldName: data.output?.fieldName ?? '',
+          fileName: data.output?.fileName ?? '',
+          totalAttachments: data.output?.totalAttachments ?? 0,
         },
       }
     },

apps/sim/tools/agiloft/types.ts

@@ -41,7 +41,7 @@ export interface AgiloftSelectRecordsParams extends AgiloftBaseParams {
   where: string
 }
 
-export interface AgiloftSavedSearchParams extends AgiloftBaseParams {}
+export type AgiloftSavedSearchParams = AgiloftBaseParams
 
 export interface AgiloftAttachmentInfoParams extends AgiloftBaseParams {
   recordId: string

apps/sim/tools/agiloft/utils.ts

@@ -27,6 +27,11 @@ interface AgiloftRequestConfig {
  */
 async function agiloftLogin(params: AgiloftBaseParams): Promise<string> {
   const base = params.instanceUrl.replace(/\/$/, '')
+
+  if (!base.startsWith('https://')) {
+    throw new Error('Agiloft instanceUrl must use HTTPS to protect credentials')
+  }
+
   const kb = encodeURIComponent(params.knowledgeBase)
   const login = encodeURIComponent(params.login)
   const password = encodeURIComponent(params.password)