fix(rootly): address PR review feedback - PATCH method, totalCount, environmentIds

waleedlatif1 · waleedlatif1 · commit a61518bf7ae9 · 2026-04-02T10:41:44.000-07:00
- Changed update_incident HTTP method from PUT to PATCH per Rootly API spec
- Fixed totalCount in all 9 list tools to use data.meta?.total_count from API response
- Added missing updateEnvironmentIds subBlock and params mapping for update_incident
diff --git a/apps/sim/blocks/blocks/rootly.ts b/apps/sim/blocks/blocks/rootly.ts
@@ -232,6 +232,14 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
       condition: { field: 'operation', value: 'rootly_update_incident' },
       mode: 'advanced',
     },
+    {
+      id: 'updateEnvironmentIds',
+      title: 'Environment IDs',
+      type: 'short-input',
+      placeholder: 'Comma-separated environment IDs',
+      condition: { field: 'operation', value: 'rootly_update_incident' },
+      mode: 'advanced',
+    },
     {
       id: 'updateGroupIds',
       title: 'Team IDs',
@@ -612,6 +620,7 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
               mitigationMessage: params.mitigationMessage,
               resolutionMessage: params.resolutionMessage,
               serviceIds: params.updateServiceIds,
+              environmentIds: params.updateEnvironmentIds,
               groupIds: params.updateGroupIds,
             }
 
@@ -742,6 +751,7 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
     mitigationMessage: { type: 'string', description: 'Mitigation message' },
     resolutionMessage: { type: 'string', description: 'Resolution message' },
     updateServiceIds: { type: 'string', description: 'Updated service IDs' },
+    updateEnvironmentIds: { type: 'string', description: 'Updated environment IDs' },
     updateGroupIds: { type: 'string', description: 'Updated team IDs' },
     listIncidentsStatus: { type: 'string', description: 'Filter by status' },
     listIncidentsSearch: { type: 'string', description: 'Search incidents' },
diff --git a/apps/sim/tools/rootly/list_alerts.ts b/apps/sim/tools/rootly/list_alerts.ts
@@ -109,7 +109,7 @@ export const rootlyListAlertsTool: ToolConfig<RootlyListAlertsParams, RootlyList
       success: true,
       output: {
         alerts,
-        totalCount: alerts.length,
+        totalCount: data.meta?.total_count ?? alerts.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_environments.ts b/apps/sim/tools/rootly/list_environments.ts
@@ -84,7 +84,7 @@ export const rootlyListEnvironmentsTool: ToolConfig<
       success: true,
       output: {
         environments,
-        totalCount: environments.length,
+        totalCount: data.meta?.total_count ?? environments.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_functionalities.ts b/apps/sim/tools/rootly/list_functionalities.ts
@@ -84,7 +84,7 @@ export const rootlyListFunctionalitiesTool: ToolConfig<
       success: true,
       output: {
         functionalities,
-        totalCount: functionalities.length,
+        totalCount: data.meta?.total_count ?? functionalities.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_incident_types.ts b/apps/sim/tools/rootly/list_incident_types.ts
@@ -84,7 +84,7 @@ export const rootlyListIncidentTypesTool: ToolConfig<
       success: true,
       output: {
         incidentTypes,
-        totalCount: incidentTypes.length,
+        totalCount: data.meta?.total_count ?? incidentTypes.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_incidents.ts b/apps/sim/tools/rootly/list_incidents.ts
@@ -138,7 +138,7 @@ export const rootlyListIncidentsTool: ToolConfig<
       success: true,
       output: {
         incidents,
-        totalCount: incidents.length,
+        totalCount: data.meta?.total_count ?? incidents.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_retrospectives.ts b/apps/sim/tools/rootly/list_retrospectives.ts
@@ -93,7 +93,7 @@ export const rootlyListRetrospectivesTool: ToolConfig<
       success: true,
       output: {
         retrospectives,
-        totalCount: retrospectives.length,
+        totalCount: data.meta?.total_count ?? retrospectives.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_services.ts b/apps/sim/tools/rootly/list_services.ts
@@ -81,7 +81,7 @@ export const rootlyListServicesTool: ToolConfig<
       success: true,
       output: {
         services,
-        totalCount: services.length,
+        totalCount: data.meta?.total_count ?? services.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_severities.ts b/apps/sim/tools/rootly/list_severities.ts
@@ -76,7 +76,7 @@ export const rootlyListSeveritiesTool: ToolConfig<
       success: true,
       output: {
         severities,
-        totalCount: severities.length,
+        totalCount: data.meta?.total_count ?? severities.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/list_teams.ts b/apps/sim/tools/rootly/list_teams.ts
@@ -78,7 +78,7 @@ export const rootlyListTeamsTool: ToolConfig<RootlyListTeamsParams, RootlyListTe
       success: true,
       output: {
         teams,
-        totalCount: teams.length,
+        totalCount: data.meta?.total_count ?? teams.length,
       },
     }
   },
diff --git a/apps/sim/tools/rootly/update_incident.ts b/apps/sim/tools/rootly/update_incident.ts
@@ -82,7 +82,7 @@ export const rootlyUpdateIncidentTool: ToolConfig<
 
   request: {
     url: (params) => `https://api.rootly.com/v1/incidents/${params.incidentId.trim()}`,
-    method: 'PUT',
+    method: 'PATCH',
     headers: (params) => ({
       'Content-Type': 'application/vnd.api+json',
       Authorization: `Bearer ${params.apiKey}`,

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ export const rootlyListAlertsTool: ToolConfig<RootlyListAlertsParams, RootlyList`
`109`	`109`	`success: true,`
`110`	`110`	`output: {`
`111`	`111`	`alerts,`
`112`		`- totalCount: alerts.length,`
	`112`	`+ totalCount: data.meta?.total_count ?? alerts.length,`
`113`	`113`	`},`
`114`	`114`	`}`
`115`	`115`	`},`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export const rootlyListEnvironmentsTool: ToolConfig<`
`84`	`84`	`success: true,`
`85`	`85`	`output: {`
`86`	`86`	`environments,`
`87`		`- totalCount: environments.length,`
	`87`	`+ totalCount: data.meta?.total_count ?? environments.length,`
`88`	`88`	`},`
`89`	`89`	`}`
`90`	`90`	`},`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ export const rootlyListIncidentsTool: ToolConfig<`
`138`	`138`	`success: true,`
`139`	`139`	`output: {`
`140`	`140`	`incidents,`
`141`		`- totalCount: incidents.length,`
	`141`	`+ totalCount: data.meta?.total_count ?? incidents.length,`
`142`	`142`	`},`
`143`	`143`	`}`
`144`	`144`	`},`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export const rootlyListRetrospectivesTool: ToolConfig<`
`93`	`93`	`success: true,`
`94`	`94`	`output: {`
`95`	`95`	`retrospectives,`
`96`		`- totalCount: retrospectives.length,`
	`96`	`+ totalCount: data.meta?.total_count ?? retrospectives.length,`
`97`	`97`	`},`
`98`	`98`	`}`
`99`	`99`	`},`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ export const rootlyListServicesTool: ToolConfig<`
`81`	`81`	`success: true,`
`82`	`82`	`output: {`
`83`	`83`	`services,`
`84`		`- totalCount: services.length,`
	`84`	`+ totalCount: data.meta?.total_count ?? services.length,`
`85`	`85`	`},`
`86`	`86`	`}`
`87`	`87`	`},`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ export const rootlyListSeveritiesTool: ToolConfig<`
`76`	`76`	`success: true,`
`77`	`77`	`output: {`
`78`	`78`	`severities,`
`79`		`- totalCount: severities.length,`
	`79`	`+ totalCount: data.meta?.total_count ?? severities.length,`
`80`	`80`	`},`
`81`	`81`	`}`
`82`	`82`	`},`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ export const rootlyListTeamsTool: ToolConfig<RootlyListTeamsParams, RootlyListTe`
`78`	`78`	`success: true,`
`79`	`79`	`output: {`
`80`	`80`	`teams,`
`81`		`- totalCount: teams.length,`
	`81`	`+ totalCount: data.meta?.total_count ?? teams.length,`
`82`	`82`	`},`
`83`	`83`	`}`
`84`	`84`	`},`