Skip to content

Commit 9c9c1f8

Browse files
waleedlatif1claude
andcommitted
chore(tour): address remaining PR review comments
- Remove unused logger import and instance in product-tour.tsx - Remove unused tour-tooltip-fade animation from tailwind config - Remove unnecessary overflow-hidden wrapper around WorkflowTour - Add border stroke to arrow SVG in tour-tooltip for visual consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d243120 commit 9c9c1f8

File tree

4 files changed

+4
-13
lines changed

4 files changed

+4
-13
lines changed

apps/sim/app/workspace/[workspaceId]/components/product-tour/product-tour.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use client'
22

33
import { useMemo } from 'react'
4-
import { createLogger } from '@sim/logger'
54
import dynamic from 'next/dynamic'
65
import { usePathname } from 'next/navigation'
76
import { navTourSteps } from '@/app/workspace/[workspaceId]/components/product-tour/nav-tour-steps'
@@ -12,8 +11,6 @@ import {
1211
} from '@/app/workspace/[workspaceId]/components/product-tour/tour-shared'
1312
import { useTour } from '@/app/workspace/[workspaceId]/components/product-tour/use-tour'
1413

15-
const logger = createLogger('NavTour')
16-
1714
const Joyride = dynamic(() => import('react-joyride'), {
1815
ssr: false,
1916
})

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/layout.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ export default function WorkflowLayout({ children }: { children: React.ReactNode
77
return (
88
<main className='flex h-full flex-1 flex-col overflow-hidden'>
99
<ErrorBoundary>{children}</ErrorBoundary>
10-
<div className='absolute h-0 w-0 overflow-hidden'>
11-
<WorkflowTour />
12-
</div>
10+
<WorkflowTour />
1311
</main>
1412
)
1513
}

apps/sim/components/emcn/components/tour-tooltip/tour-tooltip.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,10 @@ function TourTooltip({
208208
height={7}
209209
viewBox='0 0 14 7'
210210
preserveAspectRatio='none'
211-
className='-mt-px fill-[var(--bg)]'
211+
className='-mt-px fill-[var(--bg)] stroke-[var(--border)]'
212212
>
213-
<polygon points='0,0 14,0 7,7' />
213+
<polygon points='0,0 14,0 7,7' className='stroke-none' />
214+
<polyline points='0,0 7,7 14,0' fill='none' strokeWidth={1} />
214215
</svg>
215216
</PopoverPrimitive.Arrow>
216217
</PopoverPrimitive.Content>

apps/sim/tailwind.config.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,6 @@ export default {
184184
from: { opacity: '0', transform: 'scale(0.96) translateY(4px)' },
185185
to: { opacity: '1', transform: 'scale(1) translateY(0)' },
186186
},
187-
'tour-tooltip-fade': {
188-
from: { opacity: '0' },
189-
to: { opacity: '1' },
190-
},
191187
},
192188
animation: {
193189
'caret-blink': 'caret-blink 1.25s ease-out infinite',
@@ -202,7 +198,6 @@ export default {
202198
'slide-in-right': 'slide-in-right 350ms ease-out forwards',
203199
'slide-in-bottom': 'slide-in-bottom 400ms cubic-bezier(0.16, 1, 0.3, 1)',
204200
'tour-tooltip-in': 'tour-tooltip-in 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94)',
205-
'tour-tooltip-fade': 'tour-tooltip-fade 150ms cubic-bezier(0.25, 0.46, 0.45, 0.94)',
206201
},
207202
},
208203
},

0 commit comments

Comments
 (0)