Skip to content

Commit 61cfb7e

Browse files
committed
improvement(knowledge): extract MaxBadge component, capture billing config once per document
1 parent 175de7c commit 61cfb7e

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import { getProviderIdFromServiceId, type OAuthProvider } from '@/lib/oauth'
2525
import { OAuthModal } from '@/app/workspace/[workspaceId]/components/oauth-modal'
2626
import { ConnectorSelectorField } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/components/connector-selector-field'
2727
import { SYNC_INTERVALS } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/consts'
28+
import { MaxBadge } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/max-badge'
2829
import { isBillingEnabled } from '@/app/workspace/[workspaceId]/settings/navigation'
2930
import { getDependsOnFields } from '@/blocks/utils'
3031
import { CONNECTOR_REGISTRY } from '@/connectors/registry'
@@ -522,11 +523,7 @@ export function AddConnectorModal({ open, onOpenChange, knowledgeBaseId }: AddCo
522523
disabled={interval.requiresMax && !hasMaxAccess}
523524
>
524525
{interval.label}
525-
{interval.requiresMax && !hasMaxAccess && (
526-
<span className='ml-1 shrink-0 rounded-[3px] bg-[var(--surface-5)] px-1 py-[1px] font-medium text-[9px] text-[var(--text-icon)] uppercase tracking-wide'>
527-
Max
528-
</span>
529-
)}
526+
{interval.requiresMax && !hasMaxAccess && <MaxBadge />}
530527
</ButtonGroupItem>
531528
))}
532529
</ButtonGroup>

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/edit-connector-modal/edit-connector-modal.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
} from '@/components/emcn'
2424
import { getSubscriptionAccessState } from '@/lib/billing/client'
2525
import { SYNC_INTERVALS } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/consts'
26+
import { MaxBadge } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/max-badge'
2627
import { isBillingEnabled } from '@/app/workspace/[workspaceId]/settings/navigation'
2728
import { CONNECTOR_REGISTRY } from '@/connectors/registry'
2829
import type { ConnectorConfig } from '@/connectors/types'
@@ -243,11 +244,7 @@ function SettingsTab({
243244
disabled={interval.requiresMax && !hasMaxAccess}
244245
>
245246
{interval.label}
246-
{interval.requiresMax && !hasMaxAccess && (
247-
<span className='ml-1 shrink-0 rounded-[3px] bg-[var(--surface-5)] px-1 py-[1px] font-medium text-[9px] text-[var(--text-icon)] uppercase tracking-wide'>
248-
Max
249-
</span>
250-
)}
247+
{interval.requiresMax && !hasMaxAccess && <MaxBadge />}
251248
</ButtonGroupItem>
252249
))}
253250
</ButtonGroup>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export function MaxBadge() {
2+
return (
3+
<span className='ml-1 shrink-0 rounded-[3px] bg-[var(--surface-5)] px-1 py-[1px] font-medium text-[9px] text-[var(--text-icon)] uppercase tracking-wide'>
4+
Max
5+
</span>
6+
)
7+
}

apps/sim/lib/knowledge/documents/service.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -516,8 +516,10 @@ export async function processDocumentAsync(
516516
embeddings.push(emb)
517517
}
518518
totalEmbeddingTokens += batchTokens
519-
embeddingIsBYOK = isBYOK
520-
embeddingModelName = modelName
519+
if (i === 0) {
520+
embeddingIsBYOK = isBYOK
521+
embeddingModelName = modelName
522+
}
521523
}
522524
}
523525

0 commit comments

Comments
 (0)