Skip to content

Commit 573ebd6

Browse files
committed
fix(credentials): remove actingUserId from ensureWorkspaceCredentialMemberships
actingUserId is not always the credential creator — sync is called from member addition, permission changes, and invitation acceptance. Creator admin is only applied in route.ts POST (direct creation). Sync paths use pure workspace permission mapping.
1 parent 305e02c commit 573ebd6

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

apps/sim/lib/credentials/environment.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ async function ensureWorkspaceCredentialMemberships(
3838
credentialId: string,
3939
memberUserIds: string[],
4040
ownerUserId: string,
41-
wsPermissionByUser: Map<string, string>,
42-
actingUserId?: string
41+
wsPermissionByUser: Map<string, string>
4342
) {
4443
if (!memberUserIds.length) return
4544

@@ -66,8 +65,7 @@ async function ensureWorkspaceCredentialMemberships(
6665
const now = new Date()
6766
const values = targetUserIds.map((memberUserId) => {
6867
const wsPermission = wsPermissionByUser.get(memberUserId)
69-
const isAdmin =
70-
memberUserId === ownerUserId || memberUserId === actingUserId || wsPermission === 'admin'
68+
const isAdmin = memberUserId === ownerUserId || wsPermission === 'admin'
7169
return {
7270
id: generateId(),
7371
credentialId,
@@ -175,8 +173,7 @@ export async function syncWorkspaceEnvCredentials(params: {
175173
credentialId,
176174
memberUserIds,
177175
workspaceRow.ownerId,
178-
wsPermissionByUser,
179-
actingUserId
176+
wsPermissionByUser
180177
)
181178
}
182179

@@ -258,8 +255,7 @@ export async function createWorkspaceEnvCredentials(params: {
258255
const membershipValues = createdIds.flatMap((credentialId) =>
259256
memberUserIds.map((memberUserId) => {
260257
const wsPermission = wsPermissionByUser.get(memberUserId)
261-
const isAdmin =
262-
memberUserId === ownerUserId || memberUserId === actingUserId || wsPermission === 'admin'
258+
const isAdmin = memberUserId === ownerUserId || wsPermission === 'admin'
263259
return {
264260
id: generateId(),
265261
credentialId,

0 commit comments

Comments
 (0)