Skip to content

Commit 060624c

Browse files
chore: fix rernders on knowledge
1 parent 59cde30 commit 060624c

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import {
1111
import { cn } from '@/lib/core/utils/cn'
1212
import { InlineRenameInput } from '@/app/workspace/[workspaceId]/components/inline-rename-input'
1313

14+
const HEADER_PLUS_ICON = <Plus className='mr-1.5 h-[14px] w-[14px] text-[var(--text-icon)]' />
15+
1416
export interface DropdownOption {
1517
label: string
1618
icon?: React.ElementType
@@ -122,7 +124,7 @@ export const ResourceHeader = memo(function ResourceHeader({
122124
variant='subtle'
123125
className='px-2 py-1 text-caption'
124126
>
125-
<Plus className='mr-1.5 h-[14px] w-[14px] text-[var(--text-icon)]' />
127+
{HEADER_PLUS_ICON}
126128
{create.label}
127129
</Button>
128130
)}

apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use client'
22

3-
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
3+
import { useCallback, useMemo, useRef, useState } from 'react'
44
import { createLogger } from '@sim/logger'
55
import { useParams, useRouter } from 'next/navigation'
66
import { Database } from '@/components/emcn/icons'
@@ -62,20 +62,16 @@ export function Knowledge() {
6262

6363
const [debouncedSearchQuery, setDebouncedSearchQuery] = useState('')
6464
const searchTimerRef = useRef<ReturnType<typeof setTimeout>>(null)
65+
const searchValueRef = useRef('')
6566

6667
const handleSearchChange = useCallback((value: string) => {
68+
searchValueRef.current = value
6769
if (searchTimerRef.current) clearTimeout(searchTimerRef.current)
6870
searchTimerRef.current = setTimeout(() => {
6971
setDebouncedSearchQuery(value)
7072
}, 300)
7173
}, [])
7274

73-
useEffect(() => {
74-
return () => {
75-
if (searchTimerRef.current) clearTimeout(searchTimerRef.current)
76-
}
77-
}, [])
78-
7975
const [isCreateModalOpen, setIsCreateModalOpen] = useState(false)
8076

8177
const [activeKnowledgeBase, setActiveKnowledgeBase] = useState<KnowledgeBaseWithDocCount | null>(
@@ -262,7 +258,9 @@ export function Knowledge() {
262258

263259
const searchConfig: SearchConfig = useMemo(
264260
() => ({
265-
value: '',
261+
get value() {
262+
return searchValueRef.current
263+
},
266264
onChange: handleSearchChange,
267265
placeholder: 'Search knowledge bases...',
268266
}),

0 commit comments

Comments
 (0)