Seeking to hover timestamp does not match actual seek position

[efb4f5ff-1298-471a-8973-3d47447115dc]

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

v4.16.7-main-21-g8e0e0d85c

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes, Nightly Demo

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
FireFox 144.0.2 and Windows 11 IoT Enterprise LTSC 24H2

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

Any will work but this is more apparent on longer videos (it is also noticeable on shorter videos but way less so i used a long example to present it). I have added a screenrecording below.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default

What did you do?

1. Hover over seekbar
2. Notice timestamp on hover
3. Click to seek
4. Notice that it didnt seek to that preview timestamp

What did you expect to happen?
Player should seek to the correct timestamp

What actually happened?

It didnt seek to the correct timestamp

firefox_UhGwHnaPTx.mp4

Are you planning to send a PR to fix it?
No

[avelad]

@absidue Do you want work on it?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@avelad is the provided information sufficient or do i need to provide additional information to find out what the cause is?

[avelad]

The information is correct, but I don't know how to fix it yet :( Sorry!

[efb4f5ff-1298-471a-8973-3d47447115dc]

Ah okay that's fine. Its definitely a pesky one

[nic6200]

I'm new to the repository :)

Upon looking, it seems like it is because hover math uses the full bar(https://github.com/shaka-project/shaka-player/blob/main/ui/seek_bar.js#L208-L212) while the range input’s native drag math(https://github.com/shaka-project/shaka-player/blob/main/ui/range_element.js#L252-L284) shrinks the usable span by the thumb width, so the preview time and actual seek diverge (it uses a percent logic, and the percentage is usually small, but very visible on larger videos).

Can I open a PR to make drag/click use the same mapping as hover?

[avelad]

Can I open a PR to make drag/click use the same mapping as hover?

@nic6200 Yes, please! But test it before send the PR. Thanks!

[nic6200]

Thanks @avelad. Please have a look whenever you get a chance: #9429. Added a recording of it working in the PR :)