From 7ee330fabbea45b2d3d25f95b0e0b0b72ea0e959 Mon Sep 17 00:00:00 2001 From: Justus Magin Date: Mon, 9 Dec 2024 15:42:20 +0100 Subject: [PATCH 1/5] mention that `issues: write` permissions should be requested --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index b93ef6d..6fec462 100644 --- a/README.md +++ b/README.md @@ -22,6 +22,10 @@ jobs: fail-fast: false ... + permissions: + # or set actions permissions in the repo settings to read/write + issues: write + ... - uses: actions/setup-python@v4 From b13de007f23bc5eb58507e33f344918e3ad4e411 Mon Sep 17 00:00:00 2001 From: Justus Magin Date: Mon, 9 Dec 2024 15:42:41 +0100 Subject: [PATCH 2/5] correct yaml syntax --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6fec462..fcfeda8 100644 --- a/README.md +++ b/README.md @@ -35,12 +35,12 @@ jobs: ... - - run: < + - run: | pip install --upgrade pytest-reportlog ... - - run: < + - run: | pytest --report-log pytest-log.jsonl ... From 9fb92230d9c1d0eb4e786ec1bb97643f8230efb8 Mon Sep 17 00:00:00 2001 From: Justus Magin Date: Mon, 9 Dec 2024 15:43:25 +0100 Subject: [PATCH 3/5] warn more strongly --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index fcfeda8..0f9ac4a 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,9 @@ How this works: To use the `issue-from-pytest-log` action in workflows, simply add a new step: +> [!WARNING] +> The action won't run properly unless either `issues: write` permissions are requested as shown above or the actions are granted read/write permissions in the repository settings. + ```yaml jobs: my-job: From a838cc56e17c67d4b48c9c5216f56963f5f73b24 Mon Sep 17 00:00:00 2001 From: Justus Magin Date: Mon, 9 Dec 2024 15:44:13 +0100 Subject: [PATCH 4/5] don't mention the setting twice --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 0f9ac4a..ef460f9 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ How this works: To use the `issue-from-pytest-log` action in workflows, simply add a new step: > [!WARNING] -> The action won't run properly unless either `issues: write` permissions are requested as shown above or the actions are granted read/write permissions in the repository settings. +> The action won't run properly unless either `issues: write` permissions are requested as shown below or the actions are granted read/write permissions in the repository settings. ```yaml jobs: @@ -26,7 +26,6 @@ jobs: ... permissions: - # or set actions permissions in the repo settings to read/write issues: write ... From 4a051714a774125780b4a8cd90e61c740bbe44d8 Mon Sep 17 00:00:00 2001 From: Justus Magin Date: Sun, 13 Jul 2025 10:59:45 -0700 Subject: [PATCH 5/5] don't recommend using the global setting for issue permissions --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ef460f9..9019435 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ How this works: To use the `issue-from-pytest-log` action in workflows, simply add a new step: > [!WARNING] -> The action won't run properly unless either `issues: write` permissions are requested as shown below or the actions are granted read/write permissions in the repository settings. +> The action won't run properly unless the `issues: write` permission is requested as shown below. ```yaml jobs: