Skip to content

Commit b4fff59

Browse files
Update tracing_metrics_recording::record_export_success() method signature to require processor arg
1 parent 87b5dfc commit b4fff59

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/agentex/lib/core/observability/tests/test_tracing_metrics_recording.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def test_record_export_success(self, monkeypatch):
114114
"agentex.lib.core.observability.tracing_metrics.get_tracing_metrics",
115115
return_value=mock_metrics,
116116
):
117-
recording.record_export_success(event_type="end", span_count=12)
117+
recording.record_export_success(event_type="end", span_count=12, processor="sgp")
118118

119119
mock_metrics.export_batches.add.assert_called_once_with(
120120
1,

src/agentex/lib/core/observability/tracing_metrics_recording.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def record_batch_phase(*, phase: str, size: int, duration_ms: float) -> None:
102102
pass
103103

104104

105-
def record_export_success(*, event_type: str, span_count: int, processor: str = "sgp") -> None:
105+
def record_export_success(*, event_type: str, span_count: int, processor: str) -> None:
106106
if not is_metrics_enabled():
107107
return
108108
try:

0 commit comments

Comments
 (0)