[master] Fix missing arg in acme state/module "dns_plugin_propagate_seconds"#64441
[master] Fix missing arg in acme state/module "dns_plugin_propagate_seconds"#64441rittycat wants to merge 1 commit into
Conversation
salt-project-bot-prod-environment
Bot
changed the title
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
Thanks for this, would you mind also adding some test coverage to ensure this does not regress in the future.
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
This will also need some tests
| if dns_plugin == "cloudflare": | ||
| cmd.append("--dns-cloudflare") | ||
| cmd.append("--dns-cloudflare-credentials {}".format(dns_plugin_credentials)) | ||
| cmd.append("--dns-cloudflare-propagation-seconds {}".format(dns_plugin_propagate_seconds)) |
There was a problem hiding this comment.
Please add docs for this new parameter as well as a .. version-added::. If you can, document the other parameters as well.
| :param https_01_address: The address the server listens to during http-01 challenge. | ||
| :param dns_plugin: Name of a DNS plugin to use (currently only 'cloudflare') | ||
| :param dns_plugin_credentials: Path to the credentials file if required by the specified DNS plugin | ||
| :param dns_plugin_propagate_seconds: Number of seconds to wait for DNS propogations before asking ACME servers to verify the DNS record. (default 10) |
There was a problem hiding this comment.
Add a .. version-added:: comment here as well.
twangboy
added
test:full
|
Closing — the author's fork was deleted so a maintainer-side rebase isn't mechanically possible on this PR. Reopened as #69404 against |
4 participants
What does this PR do?
Adds the function arguments, and the cmd append required to make the documented argument 'dns_plugin_propagate_seconds` work
What issues does this PR fix or reference?
Fixes: #63700
Previous Behavior
The argument was documented but did not exist in code
New Behavior
The relevant code was added for both state and module, and documented in state
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.